[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] libpoke: Add `format`
|
From: |
Mohammad-Reza Nabipoor |
|
Subject: |
Re: [PATCH v2 3/3] libpoke: Add `format` |
|
Date: |
Sat, 12 Jun 2021 20:56:12 +0430 |
On Sat, Jun 12, 2021 at 04:47:52PM +0200, Jose E. Marchesi wrote:
>
> >> What about reformatting the error messages so we don't need this
> >> attribute? I am thinking on diagnostic messages like: "couldn't promote
> >> format argument initializer" and "not enough arguments for format
> >> string".
> >>
> >> WDYT?
> >>
> >
> > I did it that way first, but I changed my mind to make things more
> > explicit.
> > But I 100% agree with removing `node_name`.
>
> The patch is OK for master, provided that.
Pushed the improved version.
Plus I changed the `libpoke:` in commit message title to `pkl:`.
> Thank you for working on this! It is very cool :)
>
It's a pleasure to work with poke community :)
[PATCH v2 2/3] pkl: Fix codegen of printf, Mohammad-Reza Nabipoor, 2021/06/07