Sorry I made a mistake, what you proposed can be and is done.
Thanks.
Hi Mohammad, A few minor comments:
1. What about removing the "value" field from "PokeValue"?
``` ## 3500 as uint<32> ## { "PokeType": { "code": "Integral", "info": { "size": 32, "signed_p": false } }, "PokeValue": { "value": 3500 } } ```
to
``` ... "PokeValue": 3500 } ```
And
``` ## "foo" ## { "PokeType": { "code": "String", }, "PokeValue": { "value": "foo" } } ```
to
``` "PokeType": { "code": "String" }, "PokeValue": "foo" ```
And in structs, instead of
``` ... "PokeValue": { "fields": [ { "value": 1 }, { "value": 2 } ], ... ```
``` ... "PokeValue": { "fields": [1, 2], ... ```
Ditto for arrays.
We can’t do that because “PokeValue” is of “type”: “object” so all “$refs” have to be of type “object”If we remove value from Values we will have something like“StringValue”: { “type”: “string"}or“IntegralValue: { “type”: “integer"}which are not of type “object”. I think the minimum we need is one property, “value”.
|