poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master is broken due to latest changes to pk-mi-json


From: Mohammad-Reza Nabipoor
Subject: Re: master is broken due to latest changes to pk-mi-json
Date: Fri, 26 Nov 2021 17:45:32 +0330

On Fri, Nov 26, 2021 at 05:35:46PM +0330, Mohammad-Reza Nabipoor wrote:
> 
> Unfortunately, we don't have access to members of `struct json_object`;
> it's an opaque type.
> 
> I think we should implement the logic using user-visible API.
> It's not that complicated.
> 
> 

Or even better approach:
  Convert JSON to string representation (using `json_object_to_json_string`)
  and `strcmp` the string representation of objects.

I think due to the fact that we just use `json_object_equal` in testsuite,
it's totally fine to use this not-so-optimized approach.
WDYT?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]