[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pkl: Get rid of string literals as exception names
From: |
Mohammad-Reza Nabipoor |
Subject: |
Re: [PATCH] pkl: Get rid of string literals as exception names |
Date: |
Sun, 30 Jan 2022 15:55:35 +0330 |
Hello, Luca.
On Sun, Jan 30, 2022 at 12:48:59PM +0100, Luca Saiu wrote:
> Hello Mohammad.
>
> On 2022-01-27 at 11:55 +0330, Mohammad-Reza Nabipoor wrote:
>
> > With this patch, I declare ARMv7 as a "supported" platform :)
>
> I find it strange that the changes introduced for ARM were not necessary
> for the other platforms as well.
>
> Is it the case that x86_64 globals are *not* accessed %rip-relative?
>
This problem expresses itself as a linker error on a x86_64 Ubuntu 16.04
container.
Linker complained about `strcpy`; which I reported on IRC (I know it's a not
good platform for reporting bugs :D). But I wasn't sure what's the root of
problem. And after fixing ARMv7, that linker error went away.
And the weird thing is that even CI system didn't spot any problem.
Yet another reason for not spoting this problem until recently, is my workflow;
in which I only use switch-dispatching. Because it's very
debug/debugger-friendly.
(I'm not sure about Jose).
Regards,
Mohammad-Reza