[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pickles: asn1-ber: fix issues in long-form length/tag handli
|
From: |
Jose E. Marchesi |
|
Subject: |
Re: [PATCH] pickles: asn1-ber: fix issues in long-form length/tag handling |
|
Date: |
Mon, 07 Mar 2022 20:11:07 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Daiki.
> This commit fixes long-form definite length decoding in BER_Length and
> BER_Data_Value, so that the octet components are ordered in big-endian
> as mentioned in [1], each length octet is not necessarily < 0x80, and
> the use of such lengths is not restricted to primitive types:
> constructed types such as SEQUENCE can also have definite length.
>
> Besides those this also fixes long-form tag number handling in
> BER_Identifier, where it is indicated with 0b11111 not 0b01111.
Thank you very much for the patch.
I have applied it on your behalf in both master and maint/poke-2.