[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libpoke: Move auto-completion global state to compiler insta
|
From: |
Mohammad-Reza Nabipoor |
|
Subject: |
Re: [PATCH] libpoke: Move auto-completion global state to compiler instance |
|
Date: |
Tue, 22 Mar 2022 20:19:45 +0430 |
On Tue, Mar 22, 2022 at 12:45:10PM +0100, Jose E. Marchesi wrote:
>
> Hi Mohammad.
>
> > 2022-03-22 Mohammad-Reza Nabipoor <mnabipoor@gnu.org>
> >
> > * libpoke/libpoke.c (struct _pk_compiler): Add auto completion
> > machinery data.
> > (pk_compiler_new_with_flags): s/malloc/calloc/.
> > (complete_attribute): Remove global state, use `pkc`.
> > (complete_struct): Likewise.
> > (complete_decl): Likewise.
> > (pk_ios_completion_function): Likewise.
> > ---
> >
> > Hi, Jose.
> >
> > Instead of having `pk_{make,free}_completion_state` functions, I decided
> > to move global state to compiler instance.
> >
> > WDYT?
>
> I would prefer for the macros you are defining (idx, iter, io, ...) to
> be upper-case.
>
Fixed.
> Other than that, OK for master.
Pushed.
Thanks.