Re: [PATCH 6/9] pkl: change `pkl_ast_format_loc' function

[Mohammad-Reza Nabipoor]

On Thu, Dec 28, 2023 at 03:22:22PM +0100, Jose E. Marchesi wrote:
> 
> > diff --git a/libpoke/pkl-ast.h b/libpoke/pkl-ast.h
> > index 0146977c..3eb0b1c2 100644
> > --- a/libpoke/pkl-ast.h
> > +++ b/libpoke/pkl-ast.h
> > @@ -2203,6 +2203,10 @@ pkl_ast_node pkl_ast_reverse (pkl_ast_node ast);
> >  char *pkl_ast_format (pkl_ast_node ast);
> >  void pkl_ast_print (FILE *fp, pkl_ast_node ast);
> >  
> > -char *pkl_ast_format_loc (pkl_ast ast, pkl_ast_loc loc);
> > +/* Format location as a string.
> > +
> > +   Null FILENAME is equal to passing "<stdin>" as the FILENAME.  */
> 
> I find that comment confusing.
> 
> What about:
> 
> "FILENAME is the name of whatever source the Poke program is read from,
>  usually the name of a file.  If it is NULL, then the source part of
>  the location is formatted assuming <stdint>."
> 
> Given that, OK.


Applied and pushed!