poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Makefile rules indentation


From: Jose E. Marchesi
Subject: Re: Makefile rules indentation
Date: Wed, 14 Feb 2024 19:16:59 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

> Jose E. Marchesi wrote:
>> > Do you prefer to keep it enabled in poke (and force mixed TAB+TAB+space
>> > indentation in some Makefile.am lines), or do you prefer to disable it?
>> 
>> Disabling it is better.
>> I don't lik ehtat rule either..
>
> Here's a proposed patch to that effect. It fixes the "make syntax-check"
> failure.
>
>
>>From 7b16135c618a0ce803bf0eb948e0bd79b3431081 Mon Sep 17 00:00:00 2001
> From: Bruno Haible <bruno@clisp.org>
> Date: Wed, 14 Feb 2024 19:08:05 +0100
> Subject: [PATCH] Disable the maint.mk makefile_TAB_only_indentation
>  syntax-check rule.
>
> * cfg.mk (local-checks-to-skip): Add sc_makefile_TAB_only_indentation.
> ---
>  cfg.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/cfg.mk b/cfg.mk
> index ecdc46f2..b7e2c160 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -3,7 +3,8 @@ old_NEWS_hash=d41d8cd98f00b204e9800998ecf8427e
>  po_file=does-not-exist
>  export _gl_TS_headers = *.h
>  
> -local-checks-to-skip =                  \
> +local-checks-to-skip = \
> +   sc_makefile_TAB_only_indentation \
>     sc_tight_scope \
>     sc_prohibit_gnu_make_extensions

OK for both master and maint/poke-4.
Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]