poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libpoke: fix building pvm.jitter on windows


From: Hannes Domani
Subject: Re: [PATCH] libpoke: fix building pvm.jitter on windows
Date: Wed, 21 Feb 2024 12:04:50 +0000 (UTC)

 Am Mittwoch, 21. Februar 2024 um 13:01:56 MEZ hat Jose E. Marchesi 
<jemarch@gnu.org> Folgendes geschrieben:

> >  Am Dienstag, 20. Februar 2024 um 20:31:54 MEZ hat Jose E. Marchesi 
> ><jemarch@gnu.org> Folgendes geschrieben:
> >
> >> Hello Hannes.
> >>
> >> This could be the right workaround, but I would prefer if it is
> >> restricted to windows targets.  I would say it is actually necessary,
> >> because in many targets gnulib will not #define raise with a replacement
> >> at all.
> >
> > I'm not sure what you mean, since you can #undef an identifier even if there
> > was no #define for it beforehand.
>
>
> Ok, but in any case I think undoing gnulib definitions would be better
> done for this particular targets and not for all.  It is unlikely we
> start using raise in pvm.jitter, but who knows.

If another target also replaces raise with a define, then I would expect
that it will get the same compile error as windows currently.


Hannes


reply via email to

[Prev in Thread] Current Thread [Next in Thread]