[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.7.9-913-gaf19e
From: |
John Darrington |
Subject: |
[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.7.9-913-gaf19e87 |
Date: |
Wed, 17 Jul 2013 16:26:25 +0000 |
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".
The branch, master has been updated
via af19e87064958dfbde7a6bf0d3d19c7b82068a11 (commit)
from 84dd482092424584843c36546b36afa23a41423d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit af19e87064958dfbde7a6bf0d3d19c7b82068a11
Author: John Darrington <address@hidden>
Date: Wed Jul 17 16:12:07 2013 +0200
REGRESSION: Fix issues found by by review
Ben reported following potential problems:
I think that if the DEPENDENT subcommand is given twice (a user error), then
the variables specified the first time will be silently leaked.
cmd_regression() has two local variables named 'i'.
I don't understand why "struct workspace" has a member 'psw' that is a
dynamically allocated array, because it looks like each element of the array
is used only during processing a single split file group. That is, I think
that 'psw' could be just a singleton, instead of an array.
I think that fill_all_vars() is wrong: if an absent var follows a not-absent
var, then vars[] will be filled with a gap and there will be a write into
unallocated memory.
Reported-by: Ben Pfaff
Avoids shadowing variable in lower scope. suggested by Ben Pfaff
-----------------------------------------------------------------------
Summary of changes:
src/language/stats/regression.c | 73 ++++++++++++++------------------------
1 files changed, 27 insertions(+), 46 deletions(-)
hooks/post-receive
--
GNU PSPP
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.7.9-913-gaf19e87,
John Darrington <=