qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/18] block: Change blk_{pread,pwrite}() param order


From: Hanna Reitz
Subject: Re: [PATCH 03/18] block: Change blk_{pread,pwrite}() param order
Date: Mon, 4 Jul 2022 17:21:19 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0

On 17.05.22 13:37, Alberto Faria wrote:
Swap 'buf' and 'bytes' around for consistency with
blk_co_{pread,pwrite}(), and in preparation to implement these functions
using generated_co_wrapper.

Callers were updated using this Coccinelle script:

     @@ expression blk, offset, buf, bytes, flags; @@
     - blk_pread(blk, offset, buf, bytes, flags)
     + blk_pread(blk, offset, bytes, buf, flags)

     @@ expression blk, offset, buf, bytes, flags; @@
     - blk_pwrite(blk, offset, buf, bytes, flags)
     + blk_pwrite(blk, offset, bytes, buf, flags)

It had no effect on hw/block/nand.c, presumably due to the #if, so that
file was updated manually.

Overly-long lines were then fixed by hand.

Signed-off-by: Alberto Faria <afaria@redhat.com>
---
  block.c                           |  2 +-
  block/block-backend.c             |  4 +--
  block/commit.c                    |  4 +--
  block/crypto.c                    |  2 +-
  block/export/fuse.c               |  4 +--
  block/parallels.c                 |  2 +-
  block/qcow.c                      |  8 +++---
  block/qcow2.c                     |  4 +--
  block/qed.c                       |  8 +++---
  block/vdi.c                       |  4 +--
  block/vhdx.c                      | 20 ++++++-------
  block/vmdk.c                      | 10 +++----
  block/vpc.c                       | 12 ++++----
  hw/arm/allwinner-h3.c             |  2 +-
  hw/arm/aspeed.c                   |  2 +-
  hw/block/block.c                  |  2 +-
  hw/block/fdc.c                    | 20 ++++++-------
  hw/block/hd-geometry.c            |  2 +-
  hw/block/m25p80.c                 |  2 +-
  hw/block/nand.c                   | 47 ++++++++++++++++---------------
  hw/block/onenand.c                | 32 ++++++++++-----------
  hw/block/pflash_cfi01.c           |  4 +--
  hw/block/pflash_cfi02.c           |  4 +--
  hw/ide/atapi.c                    |  4 +--
  hw/misc/mac_via.c                 |  4 +--
  hw/misc/sifive_u_otp.c            | 14 ++++-----
  hw/nvram/eeprom_at24c.c           |  4 +--
  hw/nvram/spapr_nvram.c            |  6 ++--
  hw/nvram/xlnx-bbram.c             |  4 +--
  hw/nvram/xlnx-efuse.c             |  4 +--
  hw/ppc/pnv_pnor.c                 |  6 ++--
  hw/sd/sd.c                        |  4 +--
  include/sysemu/block-backend-io.h |  4 +--
  migration/block.c                 |  6 ++--
  nbd/server.c                      |  8 +++---
  qemu-img.c                        | 18 ++++++------
  qemu-io-cmds.c                    |  4 +--
  tests/unit/test-block-iothread.c  |  8 +++---
  38 files changed, 150 insertions(+), 149 deletions(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]