|
From: | Richard Henderson |
Subject: | Re: [PATCH for-7.1?] kvm: don't use perror() without useful errno |
Date: | Thu, 28 Jul 2022 10:13:59 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 |
On 7/28/22 07:24, Cornelia Huck wrote:
perror() is designed to append the decoded errno value to a string. This, however, only makes sense if we called something that actually sets errno prior to that. For the callers that check for split irqchip support that is not the case, and we end up with confusing error messages that end in "success". Use error_report() instead. Signed-off-by: Cornelia Huck<cohuck@redhat.com> ---
Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
[Prev in Thread] | Current Thread | [Next in Thread] |