Re: [PATCH v2 17/66] target/arm: Add is_secure parameter to get_phys_addr_lpae

[Peter Maydell]

On Mon, 22 Aug 2022 at 17:33, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Remove the use of regime_is_secure from get_phys_addr_lpae,
> using the new parameter instead.
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


> @@ -2334,7 +2334,7 @@ bool get_phys_addr(CPUARMState *env, target_ulong 
> address,
>              memset(result, 0, sizeof(*result));
>
>              ret = get_phys_addr_lpae(env, ipa, access_type, s2_mmu_idx,
> -                                     is_el0, result, fi);
> +                                     ipa_secure, is_el0, result, fi);
>              fi->s2addr = ipa;

Depending on how we change patch 2, this may want to be looking at
something other than ipa_secure.

thanks
-- PMM