[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 0/6] aspeed: avocado test boosts
From: |
Cédric Le Goater |
Subject: |
[PATCH 0/6] aspeed: avocado test boosts |
Date: |
Fri, 23 Sep 2022 10:47:57 +0200 |
Hello,
Alex's patchset [1] showed that by avoiding the class cast checkers in
hot code paths, performance is greatly improved. See results below.
This is a partial resend of [1] plus an extra caching a reference on
the AspeedSMC class, which adds an extra 10% boost.
Thanks ,
C.
[1] http://patchwork.ozlabs.org/project/qemu-devel/list/?series=313458
On a ThinkPad T480 i7-8650U,
Before :
$ build/tests/venv/bin/avocado --show=app run
build/tests/avocado/machine_aspeed.py
...
(1/7) AST1030Machine.test_ast1030_zephyros: PASS (0.21 s)
(2/7) AST2x00Machine.test_arm_ast2400_palmetto_openbmc_v2_9_0: PASS (23.51 s)
(3/7) AST2x00Machine.test_arm_ast2500_romulus_openbmc_v2_9_0: PASS (39.59 s)
(4/7) AST2x00Machine.test_arm_ast2500_evb_buildroot: PASS (23.74 s)
(5/7) AST2x00Machine.test_arm_ast2600_evb_buildroot: PASS (34.44 s)
(6/7) AST2x00MachineSDK.test_arm_ast2500_evb_sdk: PASS (91.13 s)
(7/7) AST2x00MachineSDK.test_arm_ast2600_evb_sdk: PASS (112.27 s)
RESULTS : PASS 7 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 |
CANCEL 0
JOB TIME : 325.72 s
After :
$ build/tests/venv/bin/avocado --show=app run
build/tests/avocado/machine_aspeed.py
...
(1/7) AST1030Machine.test_ast1030_zephyros: PASS (0.22 s)
(2/7) AST2x00Machine.test_arm_ast2400_palmetto_openbmc_v2_9_0: PASS (12.44 s)
(3/7) AST2x00Machine.test_arm_ast2500_romulus_openbmc_v2_9_0: PASS (13.98 s)
(4/7) AST2x00Machine.test_arm_ast2500_evb_buildroot: PASS (11.74 s)
(5/7) AST2x00Machine.test_arm_ast2600_evb_buildroot: PASS (15.90 s)
(6/7) AST2x00MachineSDK.test_arm_ast2500_evb_sdk: PASS (66.75 s)
(7/7) AST2x00MachineSDK.test_arm_ast2600_evb_sdk: PASS (82.34 s)
RESULTS : PASS 7 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 |
CANCEL 0
JOB TIME : 204.33 s
Alex Bennée (4):
cpu: cache CPUClass in CPUState for hot code paths
hw/core/cpu-sysemu: used cached class in cpu_asidx_from_attrs
cputlb: used cached CPUClass in our hot-paths
ssi: cache SSIPeripheralClass to avoid GET_CLASS()
Cédric Le Goater (2):
tests/avocado/machine_aspeed.py: Fix typos on buildroot
aspeed/smc: Cache AspeedSMCClass
include/hw/core/cpu.h | 9 +++++++++
include/hw/ssi/aspeed_smc.h | 2 ++
include/hw/ssi/ssi.h | 3 +++
accel/tcg/cputlb.c | 15 ++++++---------
cpu.c | 9 ++++-----
hw/core/cpu-sysemu.c | 5 ++---
hw/ssi/aspeed_smc.c | 9 ++++-----
hw/ssi/ssi.c | 18 ++++++++----------
tests/avocado/machine_aspeed.py | 16 ++++++++--------
9 files changed, 46 insertions(+), 40 deletions(-)
--
2.37.3
- [PATCH 0/6] aspeed: avocado test boosts,
Cédric Le Goater <=
- [PATCH 1/6] tests/avocado/machine_aspeed.py: Fix typos on buildroot, Cédric Le Goater, 2022/09/23
- [PATCH 4/6] cputlb: used cached CPUClass in our hot-paths, Cédric Le Goater, 2022/09/23
- [PATCH 3/6] hw/core/cpu-sysemu: used cached class in cpu_asidx_from_attrs, Cédric Le Goater, 2022/09/23
- [PATCH 2/6] cpu: cache CPUClass in CPUState for hot code paths, Cédric Le Goater, 2022/09/23
- [PATCH 6/6] aspeed/smc: Cache AspeedSMCClass, Cédric Le Goater, 2022/09/23
- [PATCH 5/6] ssi: cache SSIPeripheralClass to avoid GET_CLASS(), Cédric Le Goater, 2022/09/23