[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/8] hw/arm/virt: Fix devicetree warning about the GIC nod
From: |
Eric Auger |
Subject: |
Re: [PATCH v2 2/8] hw/arm/virt: Fix devicetree warning about the GIC node |
Date: |
Tue, 27 Sep 2022 14:48:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 |
Hi Jean,
On 9/27/22 12:03, Jean-Philippe Brucker wrote:
> The GICv3 bindings requires a #msi-cells property for the ITS node. Fix
> the corresponding dt-validate warning:
>
> interrupt-controller@8000000: msi-controller@8080000: '#msi-cells' is a
> required property
> From schema:
> linux/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml
nit: you may add
linux/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml
says
"#msi-cells":
description:
The single msi-cell is the DeviceID of the device which will
generate
the MSI.
const: 1
>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Besides,
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Eric
> ---
> hw/arm/virt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 83ab1a37fb..ed6f1ac41e 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -487,6 +487,7 @@ static void fdt_add_its_gic_node(VirtMachineState *vms)
> qemu_fdt_setprop_string(ms->fdt, nodename, "compatible",
> "arm,gic-v3-its");
> qemu_fdt_setprop(ms->fdt, nodename, "msi-controller", NULL, 0);
> + qemu_fdt_setprop_cell(ms->fdt, nodename, "#msi-cells", 1);
> qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg",
> 2, vms->memmap[VIRT_GIC_ITS].base,
> 2, vms->memmap[VIRT_GIC_ITS].size);
- [PATCH v2 0/8] hw/arm/virt: Fix dt-schema warnings, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 1/8] hw/arm/virt: Fix devicetree warning about the root node, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 2/8] hw/arm/virt: Fix devicetree warning about the GIC node, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 6/8] hw/arm/virt: Fix devicetree warning about the SMMU node, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 5/8] hw/arm/virt: Fix devicetree warnings about the GPIO node, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 3/8] hw/arm/virt: Use "msi-map" devicetree property for PCI, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 4/8] hw/arm/virt: Fix devicetree warning about the gpio-key node, Jean-Philippe Brucker, 2022/09/27