Re: [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM

[BALATON Zoltan]

On Sat, 1 Feb 2025, Philippe Mathieu-Daudé wrote:
> - Deprecate the 'raspi4b' machine name, renaming it as
>  'raspi4b-1g' on 32-bit hosts, 'raspi4b-2g' otherwise.
> - Add the 'raspi4b-4g' and 'raspi4b-8g' machines, with
>  respectively 4GB and 8GB of DRAM.

IMHO (meaning you can ignore it, just my opinion) if the only difference 
is the memory size -machine raspi4b -memory 4g would be better user 
experience than having a lot of different machines. Or if you want to 
emphasize these are tied to revisions maybe -machine raspi4b,revision=1.4 
could be used. You can say that -machine help listing different versions 
is easier to find but if it's the same machine with different options then 
this should be a machine option, then you can use -machine raspi4b,help to 
find the options specific to the machine. Memory size is normally set with 
-memory so that could also select the revision as a convenience if this 
is tied to a specific revision.

Regards,
BALATON Zoltan

> Philippe Mathieu-Daudé (7):
>  hw/arm/raspi4b: Declare machine types using DEFINE_TYPES() macro
>  hw/arm/raspi4b: Introduce abstract raspi4-base machine type
>  hw/arm/raspi4b: Split raspi4b_machine_class_init() in two (1g and 2g)
>  hw/arm/raspi4b: Rename as raspi4b-1g / raspi4b-2g, deprecating old
>    name
>  hw/arm/raspi4b: Expose the raspi4b-1g machine on 64-bit hosts
>  hw/arm/raspi4b: Add the raspi4b-4g machine
>  hw/arm/raspi4b: Add the raspi4b-8g machine
>
> docs/about/deprecated.rst |  6 +++
> hw/arm/raspi4b.c          | 91 +++++++++++++++++++++++++++++++--------
> 2 files changed, 79 insertions(+), 18 deletions(-)