qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-10.0 0/3] hw/boards: Try to make sense of MachineClass::n


From: Thomas Huth
Subject: Re: [PATCH-for-10.0 0/3] hw/boards: Try to make sense of MachineClass::no_sdcard flag
Date: Tue, 4 Feb 2025 08:11:00 +0100
User-agent: Mozilla Thunderbird

On 26/11/2024 06.24, Philippe Mathieu-Daudé wrote:
On 25/11/24 19:14, Philippe Mathieu-Daudé wrote:
Invert MachineClass 'no_sdcard' flag logic and rename it
to 'create_default_sdcard_drive' to make sense of this
default value applied to all machines. No logical change
intended.

Philippe Mathieu-Daudé (3):
   hw/boards: Convert no_sdcard flag to OnOffAuto tri-state
   hw/boards: Explicit no_sdcard=false as ON_OFF_AUTO_OFF
   hw/boards: Rename no_sdcard -> create_default_sdcard_drive

Sorry, this felt through the cracks, but I think this series here is indeed a much better idea than the code churn in your other series that simply changes the bitfields into booleans.

I expect next steps to be:

  - Remove nonsense create_default_sdcard_drive (where
    machines don't have SDHCI devices)

A fourth patch like this would be very welcome, too!

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]