Re: [PATCH v2 5/8] hw/ppc/e500: Remove empty ppce500_machine_class_init()

[Thomas Huth]

On 04/02/2025 19.12, Philippe Mathieu-Daudé wrote:
> On 4/2/25 19:07, Philippe Mathieu-Daudé wrote:
> > Previous commit left this method empty, remove it.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   hw/ppc/e500.c | 5 -----
> >   1 file changed, 5 deletions(-)
> >
> > diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
> > index 59208da87de..26933e0457e 100644
> > --- a/hw/ppc/e500.c
> > +++ b/hw/ppc/e500.c
> > @@ -1285,10 +1285,6 @@ static void e500_ccsr_initfn(Object *obj)
> >                          MPC8544_CCSRBAR_SIZE);
> >   }
> > -static void ppce500_machine_class_init(ObjectClass *oc, void *data)
> > -{
> > -}
>
> Hmm I think it is a left-over and shouldn't be necessary in patch #2.

In case you want to keep it (or want to squash it into the previous patch):

Reviewed-by: Thomas Huth <thuth@redhat.com>