[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 10/17] hw/arm/xlnx-zynqmp: Use &error_abort for programmin
|
From: |
Anton Johansson |
|
Subject: |
Re: [PATCH v3 10/17] hw/arm/xlnx-zynqmp: Use &error_abort for programming errors |
|
Date: |
Wed, 5 Feb 2025 01:21:12 +0100 |
On 04/02/25, Philippe Mathieu-Daudé wrote:
> ping for trivial review?
>
> On 8/11/24 16:43, Philippe Mathieu-Daudé wrote:
> > When a property value is static (not provided by QMP or CLI),
> > error shouldn't happen, otherwise it is a programming error.
> > Therefore simplify and use &error_abort as this can't fail.
> >
> > Reported-by: Richard Henderson <richard.henderson@linaro.org>
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> > hw/arm/xlnx-zynqmp.c | 44 ++++++++++++++------------------------------
> > 1 file changed, 14 insertions(+), 30 deletions(-)
> >
Makes sense!:)
Reviewed-by: Anton Johansson <anjo@rev.ng>