Re: [PATCH v1 12/18] hw/arm/aspeed_ast27x0: Support two levels of INTC controllers for AST2700 A1

[Cédric Le Goater]

On 2/6/25 06:15, Jamin Lin wrote:
> Hi Joel,
>
> > From: Joel Stanley <joel@jms.id.au>
> > Sent: Thursday, February 6, 2025 12:55 PM
> > To: Jamin Lin <jamin_lin@aspeedtech.com>
> > Cc: Andrew Jeffery <andrew@codeconstruct.com.au>; Cédric Le Goater
> > <clg@kaod.org>; Peter Maydell <peter.maydell@linaro.org>; Steven Lee
> > <steven_lee@aspeedtech.com>; Troy Lee <leetroy@gmail.com>; open
> > list:ASPEED BMCs <qemu-arm@nongnu.org>; open list:All patches CC here
> > <qemu-devel@nongnu.org>; Troy Lee <troy_lee@aspeedtech.com>; Yunlin
> > Tang <yunlin.tang@aspeedtech.com>
> > Subject: Re: [PATCH v1 12/18] hw/arm/aspeed_ast27x0: Support two levels of
> > INTC controllers for AST2700 A1
> >
> > Hi Jamin,
> >
> > On Thu, 6 Feb 2025 at 10:09, Andrew Jeffery <andrew@codeconstruct.com.au>
> > wrote:
> > > Thanks, I'll consider this updated diagram as well while I put my own
> > > together from the other pieces of info you've provided.
> >
> > When you send the next version, please try to separate your code cleanups and
> > minor renames into a different patch. It makes it easier to see what you're
> > adding.
> >
> > Thanks,
> >
> > Joel
>
> Thanks for suggestion. Cedric, also made the same suggestion in patch 0,
> https://patchwork.kernel.org/project/qemu-devel/cover/20250121070424.2465942-1-jamin_lin@aspeedtech.com/
>
> I think I will re-send this first.

> 1. INTC rename/prereqs/cleanups
>     hw/intc/aspeed: Rename INTC to INTC0

I thought we were keeping INTC and introducing INTC_IO ? As
you wish.

If we choose to rename INTC to INTC0, I prefer that you send
the series below first.


>     hw/intc/aspeed: Support different memory region ops
>     hw/intc/aspeed: Introduce a new aspeed_2700_intc0_ops for INTC0
>     hw/intc/aspeed: Support setting different memory and register size
>     hw/intc/aspeed: Introduce helper functions for enable and status registers
>     hw/intc/aspeed: Add ID to trace events for better debugging
>     hw/arm/aspeed: Rename IRQ table and machine name for AST2700 A0

Thanks,

C.