[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 1/5] qapi/qom: Introduce kvm-pmu-filter object
From: |
Zhao Liu |
Subject: |
Re: [RFC v2 1/5] qapi/qom: Introduce kvm-pmu-filter object |
Date: |
Thu, 6 Feb 2025 18:27:48 +0800 |
> > > @@ -1183,6 +1185,7 @@
> > > 'if': 'CONFIG_LINUX' },
> > > 'iommufd': 'IOMMUFDProperties',
> > > 'iothread': 'IothreadProperties',
> > > + 'kvm-pmu-filter': 'KVMPMUFilterPropertyVariant',
> >
> > The others are like
> >
> > 'mumble': 'MumbleProperties'
> >
> > Let's stick to that, and also avoid running together multiple
> > capitalized acronyms: KvmPmuFilterProperties.
>
> IIUC, then I should use the name "KvmPmuFilterProperties" (string version
> for QAPI), and the name "KvmPmuFilterPropertiesVariant" (numeric version
> in codes), do you agree?
>
Thanks to Daniel's feedback, pmu filter doesn't need the string version
anymore. So there's only 1 "KvmPmuFilterProperties" structure in QAPI.