Re: [PATCH v4 09/17] hw/misc: Support 8-bytes memop in NPCM GCR module

[Philippe Mathieu-Daudé]

On 6/2/25 23:11, Hao Wu wrote:
> The NPCM8xx GCR device can be accessed with 64-bit memory operations.
> This patch supports that.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Hao Wu <wuhaotsh@google.com>
> ---
>   hw/misc/npcm_gcr.c   | 94 +++++++++++++++++++++++++++++++++-----------
>   hw/misc/trace-events |  4 +-
>   2 files changed, 74 insertions(+), 24 deletions(-)


>   static const struct MemoryRegionOps npcm_gcr_ops = {
> @@ -261,7 +310,8 @@ static const struct MemoryRegionOps npcm_gcr_ops = {
>       .endianness = DEVICE_LITTLE_ENDIAN,
>       .valid      = {
>           .min_access_size        = 4,
> -        .max_access_size        = 4,
> +        .max_access_size        = 8,
> +        .accepts                = npcm_gcr_check_mem_op,

Good idea to implement the accepts() handler!

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>           .unaligned              = false,
>       },
>   };