Re: [PATCH v4 15/17] hw/arm: Add NPCM8XX SoC

[Philippe Mathieu-Daudé]

On 6/2/25 23:12, Hao Wu wrote:
> Signed-off-by: Hao Wu <wuhaotsh@google.com>
> ---
>   configs/devices/aarch64-softmmu/default.mak |   1 +
>   hw/arm/Kconfig                              |  13 +
>   hw/arm/meson.build                          |   1 +
>   hw/arm/npcm8xx.c                            | 804 ++++++++++++++++++++
>   include/hw/arm/npcm8xx.h                    | 107 +++
>   5 files changed, 926 insertions(+)
>   create mode 100644 hw/arm/npcm8xx.c
>   create mode 100644 include/hw/arm/npcm8xx.h


> diff --git a/include/hw/arm/npcm8xx.h b/include/hw/arm/npcm8xx.h
> new file mode 100644
> index 0000000000..2c8cfb1289
> --- /dev/null
> +++ b/include/hw/arm/npcm8xx.h
> @@ -0,0 +1,107 @@
> +/*
> + * Nuvoton NPCM8xx SoC family.
> + *
> + * Copyright 2022 Google LLC
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
> + * for more details.
> + */
> +#ifndef NPCM8XX_H
> +#define NPCM8XX_H
> +
> +#include "hw/boards.h"

Not necessary (MachineState is forward-declarated).

> +#include "hw/adc/npcm7xx_adc.h"
> +#include "hw/core/split-irq.h"
> +#include "hw/cpu/cluster.h"
> +#include "hw/gpio/npcm7xx_gpio.h"
> +#include "hw/i2c/npcm7xx_smbus.h"
> +#include "hw/intc/arm_gic_common.h"
> +#include "hw/mem/npcm7xx_mc.h"
> +#include "hw/misc/npcm_clk.h"
> +#include "hw/misc/npcm_gcr.h"
> +#include "hw/misc/npcm7xx_mft.h"
> +#include "hw/misc/npcm7xx_pwm.h"
> +#include "hw/misc/npcm7xx_rng.h"
> +#include "hw/net/npcm7xx_emc.h"
> +#include "hw/nvram/npcm7xx_otp.h"
> +#include "hw/sd/npcm7xx_sdhci.h"
> +#include "hw/timer/npcm7xx_timer.h"
> +#include "hw/ssi/npcm7xx_fiu.h"
> +#include "hw/usb/hcd-ehci.h"
> +#include "hw/usb/hcd-ohci.h"
> +#include "target/arm/cpu.h"


> +/**
> + * npcm8xx_load_kernel - Loads memory with everything needed to boot
> + * @machine - The machine containing the SoC to be booted.
> + * @soc - The SoC containing the CPU to be booted.
> + *
> + * This will set up the ARM boot info structure for the specific NPCM8xx
> + * derivative and call arm_load_kernel() to set up loading of the kernel, etc.
> + * into memory, if requested by the user.
> + */
> +void npcm8xx_load_kernel(MachineState *machine, NPCM8xxState *soc);
> +
> +#endif /* NPCM8XX_H */