Re: [PATCH 03/10] target/arm: Set disassemble_info::endian value in disas_set_info()

[Philippe Mathieu-Daudé]

On 27/1/25 14:57, Thomas Huth wrote:
> On 27/01/2025 12.54, Philippe Mathieu-Daudé wrote:
> > Have the CPUClass::disas_set_info() callback set the
> > disassemble_info::endian field.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   target/arm/cpu.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/target/arm/cpu.c b/target/arm/cpu.c
> > index f9fdf708653..9de8c799c77 100644
> > --- a/target/arm/cpu.c
> > +++ b/target/arm/cpu.c
> > @@ -1220,6 +1220,8 @@ static void arm_disas_set_info(CPUState *cpu, 
> > disassemble_info *info)
> >   #else
> >           info->endian = BFD_ENDIAN_BIG;
> >   #endif
> > +    } else {
> > +        info->endian = BFD_ENDIAN_LITTLE;
> >       }
>
> I'd maybe rather go with something like this:
>
>      info->endian = BFD_ENDIAN_LITTLE;
> #if TARGET_BIG_ENDIAN
>      if (bswap_code(sctlr_b)) {
>          info->endian = BFD_ENDIAN_LITTLE;
>      }

This misses:

       else {
           info->endian = BFD_ENDIAN_BIG;
       }

> #endif
>
> What do you think?

I'll go with Richard's ternary suggestion for v2 and see :)