Re: [PATCH v2 18/18] hw/rtc: Add Ricoh RS5C372 RTC emulation

[Bernhard Beschow]

Am 10. Februar 2025 14:26:00 UTC schrieb "Philippe Mathieu-Daudé" 
<philmd@linaro.org>:
>On 6/2/25 22:58, Bernhard Beschow wrote:
>> 
>> 
>> Am 6. Februar 2025 17:32:31 UTC schrieb Peter Maydell 
>> <peter.maydell@linaro.org>:
>>> On Tue, 4 Feb 2025 at 09:21, Bernhard Beschow <shentey@gmail.com> wrote:
>>>> 
>>>> The implementation just allows Linux to determine date and time.
>>>> 
>>>> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
>>>> ---
>>>>   MAINTAINERS         |   1 +
>>>>   hw/rtc/rs5c372.c    | 227 ++++++++++++++++++++++++++++++++++++++++++++
>>>>   hw/rtc/Kconfig      |   5 +
>>>>   hw/rtc/meson.build  |   1 +
>>>>   hw/rtc/trace-events |   4 +
>>>>   5 files changed, 238 insertions(+)
>>>>   create mode 100644 hw/rtc/rs5c372.c
>>> 
>>> Should there be a patch after this one that adds this device
>>> to your board ?
>> 
>> As per Kconfig the board selects I2C_DEVICES and this device is "default y 
>> if I2C_DEVICES". I've deliberately not hardcoded this device to the board to 
>> make it emulate a plain i.MX 8M Plus SoC (see also board documentation).
>
>Then maybe add a test to be sure it is not bitroting?

Good idea. I haven't written a test in QEMU yet but I could certainly draw some 
inspiration from ds1338-test.c. This may take an iteration longer but won't be 
forgotten.

Best regards,
Bernhard