[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 09/10] tests/functional: Remove sleep() kludges from microblaz
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v7 09/10] tests/functional: Remove sleep() kludges from microblaze tests |
Date: |
Wed, 12 Feb 2025 13:36:58 +0100 |
Commit f0ec14c78c4 ("tests/avocado: Fix console data loss") fixed
QEMUMachine's problem with console, we don't need to use the sleep()
kludges.
Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20250206131052.30207-15-philmd@linaro.org>
---
tests/functional/test_microblazeel_s3adsp1800.py | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/tests/functional/test_microblazeel_s3adsp1800.py
b/tests/functional/test_microblazeel_s3adsp1800.py
index 715ef3f79ac..60aab4a45e8 100755
--- a/tests/functional/test_microblazeel_s3adsp1800.py
+++ b/tests/functional/test_microblazeel_s3adsp1800.py
@@ -7,8 +7,7 @@
# This work is licensed under the terms of the GNU GPL, version 2 or
# later. See the COPYING file in the top-level directory.
-import time
-from qemu_test import exec_command, exec_command_and_wait_for_pattern
+from qemu_test import exec_command_and_wait_for_pattern
from qemu_test import QemuSystemTest, Asset
from qemu_test import wait_for_console_pattern
@@ -31,9 +30,8 @@ def do_xmaton_le_test(self, machine):
self.vm.add_args('-nic', f'user,tftp={tftproot}')
self.vm.launch()
wait_for_console_pattern(self, 'QEMU Advent Calendar 2023')
- time.sleep(0.1)
- exec_command(self, 'root')
- time.sleep(0.1)
+ wait_for_console_pattern(self, 'buildroot login:')
+ exec_command_and_wait_for_pattern(self, 'root', '#')
exec_command_and_wait_for_pattern(self,
'tftp -g -r xmaton.png 10.0.2.2 ; md5sum xmaton.png',
'821cd3cab8efd16ad6ee5acc3642a8ea')
--
2.47.1
- Re: [PATCH v7 02/10] hw/intc/xilinx_intc: Make device endianness configurable, (continued)
- [PATCH v7 04/10] hw/timer/xilinx_timer: Make device endianness configurable, Philippe Mathieu-Daudé, 2025/02/12
- [PATCH v7 03/10] hw/net/xilinx_ethlite: Make device endianness configurable, Philippe Mathieu-Daudé, 2025/02/12
- [PATCH v7 05/10] hw/char/xilinx_uartlite: Make device endianness configurable, Philippe Mathieu-Daudé, 2025/02/12
- [PATCH v7 06/10] hw/ssi/xilinx_spi: Make device endianness configurable, Philippe Mathieu-Daudé, 2025/02/12
- [PATCH v7 09/10] tests/functional: Remove sleep() kludges from microblaze tests,
Philippe Mathieu-Daudé <=
- [PATCH v7 10/10] tests/functional: Have microblaze tests inherit common parent class, Philippe Mathieu-Daudé, 2025/02/12
- [PATCH v7 08/10] tests/functional: Allow microblaze tests to take a machine name argument, Philippe Mathieu-Daudé, 2025/02/12
- [PATCH v7 07/10] tests/functional: Explicit endianness of microblaze assets, Philippe Mathieu-Daudé, 2025/02/12