[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/8] hw/arm/exynos4210: Specify explicitly the GIC has 64 exte
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 2/8] hw/arm/exynos4210: Specify explicitly the GIC has 64 external IRQs |
Date: |
Wed, 12 Feb 2025 16:43:27 +0100 |
When not specified, Cortex-A9MP configures its GIC with 64 external
IRQs (see commit a32134aad89 "arm:make the number of GIC interrupts
configurable"). Add the GIC_EXT_IRQS definition (with a comment)
to make that explicit.
Except explicitly setting a property value to its same implicit
value, there is no logical change intended.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/arm/exynos4210.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c
index b6537a2d64a..b452470598b 100644
--- a/hw/arm/exynos4210.c
+++ b/hw/arm/exynos4210.c
@@ -103,6 +103,8 @@
#define EXYNOS4210_PL330_BASE1_ADDR 0x12690000
#define EXYNOS4210_PL330_BASE2_ADDR 0x12850000
+#define GIC_EXT_IRQS 64 /* FIXME: verify for this SoC */
+
enum ExtGicId {
EXT_GIC_ID_MDMA_LCD0 = 66,
EXT_GIC_ID_PDMA0,
@@ -588,6 +590,8 @@ static void exynos4210_realize(DeviceState *socdev, Error
**errp)
/* Private memory region and Internal GIC */
qdev_prop_set_uint32(DEVICE(&s->a9mpcore), "num-cpu", EXYNOS4210_NCPUS);
+ qdev_prop_set_uint32(DEVICE(&s->a9mpcore), "num-irq",
+ GIC_EXT_IRQS + GIC_INTERNAL);
busdev = SYS_BUS_DEVICE(&s->a9mpcore);
sysbus_realize(busdev, &error_fatal);
sysbus_mmio_map(busdev, 0, EXYNOS4210_SMP_PRIVATE_BASE_ADDR);
--
2.47.1
- [PATCH v2 0/8] hw/arm: Explicit number of GIC external IRQs for Cortex A9/A15 MPCore, Philippe Mathieu-Daudé, 2025/02/12
- [PATCH v2 1/8] hw/arm/exynos4210: Replace magic 32 by proper 'GIC_INTERNAL' definition, Philippe Mathieu-Daudé, 2025/02/12
- [PATCH v2 2/8] hw/arm/exynos4210: Specify explicitly the GIC has 64 external IRQs,
Philippe Mathieu-Daudé <=
- [PATCH v2 3/8] hw/arm/realview: Specify explicitly the GIC has 64 external IRQs, Philippe Mathieu-Daudé, 2025/02/12
- [PATCH v2 5/8] hw/arm/xilinx_zynq: Specify explicitly the GIC has 64 external IRQs, Philippe Mathieu-Daudé, 2025/02/12
- [PATCH v2 4/8] hw/arm/xilinx_zynq: Replace IRQ_OFFSET -> GIC_INTERNAL, Philippe Mathieu-Daudé, 2025/02/12
- [PATCH v2 6/8] hw/arm/vexpress: Specify explicitly the GIC has 64 external IRQs, Philippe Mathieu-Daudé, 2025/02/12
- [PATCH v2 7/8] hw/arm/highbank: Specify explicitly the GIC has 128 external IRQs, Philippe Mathieu-Daudé, 2025/02/12
- [PATCH v2 8/8] hw/cpu/arm_mpcore: Remove default values for GIC external IRQs, Philippe Mathieu-Daudé, 2025/02/12
- Re: [PATCH v2 0/8] hw/arm: Explicit number of GIC external IRQs for Cortex A9/A15 MPCore, Peter Maydell, 2025/02/17