[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/4] acpi/ghes: Make ghes_record_cper_errors() static
From: |
Gavin Shan |
Subject: |
[PATCH 1/4] acpi/ghes: Make ghes_record_cper_errors() static |
Date: |
Fri, 14 Feb 2025 14:16:32 +1000 |
acpi_ghes_memory_errors() is the only caller, no need to expose
the function. Besides, the last 'return' in this function isn't
necessary and remove it.
No functional changes intended.
Signed-off-by: Gavin Shan <gshan@redhat.com>
---
hw/acpi/ghes.c | 6 ++----
include/hw/acpi/ghes.h | 2 --
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
index b709c177cd..b85bb48195 100644
--- a/hw/acpi/ghes.c
+++ b/hw/acpi/ghes.c
@@ -390,8 +390,8 @@ static void get_hw_error_offsets(uint64_t ghes_addr,
*read_ack_register_addr = ghes_addr + sizeof(uint64_t);
}
-void ghes_record_cper_errors(const void *cper, size_t len,
- uint16_t source_id, Error **errp)
+static void ghes_record_cper_errors(const void *cper, size_t len,
+ uint16_t source_id, Error **errp)
{
uint64_t cper_addr = 0, read_ack_register_addr = 0, read_ack_register;
AcpiGedState *acpi_ged_state;
@@ -440,8 +440,6 @@ void ghes_record_cper_errors(const void *cper, size_t len,
/* Write the generic error data entry into guest memory */
cpu_physical_memory_write(cper_addr, cper, len);
-
- return;
}
int acpi_ghes_memory_errors(uint16_t source_id, uint64_t physical_address)
diff --git a/include/hw/acpi/ghes.h b/include/hw/acpi/ghes.h
index 39619a2457..578a582203 100644
--- a/include/hw/acpi/ghes.h
+++ b/include/hw/acpi/ghes.h
@@ -75,8 +75,6 @@ void acpi_build_hest(GArray *table_data, GArray
*hardware_errors,
void acpi_ghes_add_fw_cfg(AcpiGhesState *vms, FWCfgState *s,
GArray *hardware_errors);
int acpi_ghes_memory_errors(uint16_t source_id, uint64_t error_physical_addr);
-void ghes_record_cper_errors(const void *cper, size_t len,
- uint16_t source_id, Error **errp);
/**
* acpi_ghes_present: Report whether ACPI GHES table is present
--
2.48.1
- [PATCH 0/4] target/arm: Improvement on memory error handling, Gavin Shan, 2025/02/13
- [PATCH 1/4] acpi/ghes: Make ghes_record_cper_errors() static,
Gavin Shan <=
- [PATCH 2/4] acpi/ghes: Use error_report() in ghes_record_cper_errors(), Gavin Shan, 2025/02/13
- [PATCH 3/4] acpi/ghes: Allow retry to write CPER errors, Gavin Shan, 2025/02/13
- [PATCH 4/4] target/arm: Retry pushing CPER error if necessary, Gavin Shan, 2025/02/13
- Re: [PATCH 4/4] target/arm: Retry pushing CPER error if necessary, Igor Mammedov, 2025/02/19
- Re: [PATCH 4/4] target/arm: Retry pushing CPER error if necessary, Gavin Shan, 2025/02/21
- Re: [PATCH 4/4] target/arm: Retry pushing CPER error if necessary, Jonathan Cameron, 2025/02/21
- Re: [PATCH 4/4] target/arm: Retry pushing CPER error if necessary, Igor Mammedov, 2025/02/25
- Re: [PATCH 4/4] target/arm: Retry pushing CPER error if necessary, Gavin Shan, 2025/02/25
- Re: [PATCH 4/4] target/arm: Retry pushing CPER error if necessary, Jonathan Cameron, 2025/02/27