[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] iotests: Drop vpc from 004's a
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] iotests: Drop vpc from 004's and 104's format list |
Date: |
Tue, 03 Mar 2015 15:06:26 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 03/03/2015 02:22 PM, Max Reitz wrote:
> Both tests require the test image to have a specific size; this cannot
> be guaranteed by vpc (unless tuning the test specifically for that
> format).
>
> It is safe to exclude vpc from 004 because what is tested there is
> implemented in a generic part in the block layer and not
> format-specific.
>
> It is safe to exclude vpc from 104 because for vpc basically every image
> size is "unaligned", so if that would break at some point in time, we
> would quickly notice just by running the generic tests.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/004 | 2 +-
> tests/qemu-iotests/104 | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature