On Wed, Mar 04, 2015 at 11:15:02PM -0500, John Snow wrote:
Reviewed-by: Max Reitz <address@hidden>
Signed-off-by: John Snow <address@hidden>
---
tests/qemu-iotests/124 | 49 ++++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/124.out | 4 ++--
2 files changed, 51 insertions(+), 2 deletions(-)
This tests seems to fail locally:
. . .
+======================================================================
+FAIL: test_incremental_failure (__main__.TestIncrementalBackup)
+Test: Verify backups made after a failure are correct.
+----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "124", line 331, in test_incremental_failure
+ self.create_incremental()
+ File "124", line 167, in create_incremental
+ return self.wait_incremental(bitmap, validate)
+ File "124", line 179, in wait_incremental
+ self.assert_qmp_absent(event, 'data/error')
+ File
"/home/kashyapc/tinker-space/qemu-upstream/tests/qemu-iotests/iotests.py", line
282, in assert_qmp_absent
+ self.fail('path "%s" has value "%s"' % (path, str(result)))
+AssertionError: path "data/error" has value "Input/output error"
+
+======================================================================
+FAIL: test_transaction_failure (__main__.TestIncrementalBackup)
+Test: Verify backups made from a transaction that partially fails.
+----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "124", line 448, in test_transaction_failure
+ self.wait_incremental(dr1bm0, 'drive1')
+ File "124", line 179, in wait_incremental
+ self.assert_qmp_absent(event, 'data/error')
+ File
"/home/kashyapc/tinker-space/qemu-upstream/tests/qemu-iotests/iotests.py", line
282, in assert_qmp_absent
+ self.fail('path "%s" has value "%s"' % (path, str(result)))
+AssertionError: path "data/error" has value "Input/output error"
+
----------------------------------------------------------------------
. . .
Complete stderr of `./check -qcow2` here:
https://kashyapc.fedorapeople.org/virt/qemu-incremental-backup-tests/stderr-qemu-io-tests-qcow2-11MAR2015.txt
And, as per the other two failures of tests 051 and 061 (that you
mentioned on #qemu yesterday), Kevin Wolf on IRC said:
051 was fixed, but the output has changed _again_. That change is from
armbru_'s commit 7ee6c1e18. We need to update the reference output.
As for 061, Max sent a patch, but I think we need to fix qemu rather
than updating the reference output there
Because the error message has become considerably worse
To test, I applied these two series to yesterday's QEMU git master:
[PATCH 00/11] block: incremental backup transactions
[PATCH v2 00/17] block: transactionless incremental backup
So, I'm here (28 commits ahead of commit 3539bbb on master) after
applying the patch series:
$ git describe
v2.2.0-1190-g41b7f5f
I need to try w/ today's git though, yet.