[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/15] iotests: remove qemu_io_silent() and qemu_io_silent_ch
|
From: |
John Snow |
|
Subject: |
Re: [PATCH 14/15] iotests: remove qemu_io_silent() and qemu_io_silent_check(). |
|
Date: |
Tue, 22 Mar 2022 13:16:41 -0400 |
On Tue, Mar 22, 2022 at 1:00 PM Hanna Reitz <hreitz@redhat.com> wrote:
>
> On 18.03.22 21:36, John Snow wrote:
> > Like qemu-img, qemu-io returning 0 should be the norm and not the
> > exception. Remove all calls to qemu_io_silent that just assert the
> > return code is zero (That's every last call, as it turns out), and
> > replace them with a normal qemu_io() call.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> > tests/qemu-iotests/216 | 12 +++++-----
> > tests/qemu-iotests/218 | 5 ++---
> > tests/qemu-iotests/224 | 4 ++--
> > tests/qemu-iotests/258 | 12 +++++-----
> > tests/qemu-iotests/298 | 16 ++++++--------
> > tests/qemu-iotests/310 | 22 +++++++++----------
> > tests/qemu-iotests/iotests.py | 16 --------------
> > tests/qemu-iotests/tests/image-fleecing | 4 ++--
> > .../tests/mirror-ready-cancel-error | 2 +-
> > .../qemu-iotests/tests/stream-error-on-reset | 4 ++--
> > 10 files changed, 39 insertions(+), 58 deletions(-)
>
> qemu_io_silent_check() was unused anyway, right...?
>
> Reviewed-by: Hanna Reitz <hreitz@redhat.com>
>
As far as I can tell.
- Re: [PATCH 06/15] iotests: rebase qemu_io() on top of qemu_tool(), (continued)
- [PATCH 11/15] iotests/migration-permissions: fixup, John Snow, 2022/03/18
- [PATCH 15/15] iotests: make qemu_io_log() check return codes by default, John Snow, 2022/03/18
- [PATCH 14/15] iotests: remove qemu_io_silent() and qemu_io_silent_check()., John Snow, 2022/03/18
- [PATCH 13/15] iotests: remove qemu_io_pipe_and_status(), John Snow, 2022/03/18
- Re: [PATCH 00/15] iotests: add enhanced debugging info to qemu-io failures, Hanna Reitz, 2022/03/22