[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 3/7] hw/ide/core: Clear LBA and drive bits for EXECUTE DEVICE
From: |
Lev Kujawski |
Subject: |
[PATCH v2 3/7] hw/ide/core: Clear LBA and drive bits for EXECUTE DEVICE DIAGNOSTIC |
Date: |
Thu, 7 Jul 2022 03:11:36 +0000 |
Prior to this patch, cmd_exec_dev_diagnostic relied upon
ide_set_signature to clear the device register. While the
preservation of the drive bit by ide_set_signature is necessary for
the DEVICE RESET, IDENTIFY DEVICE, and READ SECTOR commands,
ATA/ATAPI-6 specifies that "DEV shall be cleared to zero" for EXECUTE
DEVICE DIAGNOSTIC.
This deviation was uncovered by the ATACT Device Testing Program
written by Hale Landis.
Signed-off-by: Lev Kujawski <lkujaw@member.fsf.org>
---
hw/ide/core.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 7cbc0a54a7..b747191ebf 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -1704,8 +1704,14 @@ static bool cmd_identify_packet(IDEState *s, uint8_t cmd)
return false;
}
+/* EXECUTE DEVICE DIAGNOSTIC */
static bool cmd_exec_dev_diagnostic(IDEState *s, uint8_t cmd)
{
+ /*
+ * Clear the device register per the ATA (v6) specification,
+ * because ide_set_signature does not clear LBA or drive bits.
+ */
+ s->select = (ATA_DEV_ALWAYS_ON);
ide_set_signature(s);
if (s->drive_kind == IDE_CD) {
--
2.34.1
- [PATCH v2 1/7] piix_ide_reset: Use pci_set_* functions instead of direct access, Lev Kujawski, 2022/07/06
- [PATCH v2 3/7] hw/ide/core: Clear LBA and drive bits for EXECUTE DEVICE DIAGNOSTIC,
Lev Kujawski <=
- [PATCH v2 2/7] tests/qtest/ide-test.c: Create disk image for use as a secondary, Lev Kujawski, 2022/07/06
- [PATCH v2 4/7] tests/qtest/ide-test: Verify that DIAGNOSTIC clears DEV to zero, Lev Kujawski, 2022/07/06
- [PATCH v2 5/7] qpci_device_enable: Allow for command bits hardwired to 0, Lev Kujawski, 2022/07/06
- [PATCH v2 6/7] hw/ide/piix: Ignore writes of hardwired PCI command register bits, Lev Kujawski, 2022/07/06
- [PATCH v2 7/7] hw/ide/core.c: Implement ATA INITIALIZE_DEVICE_PARAMETERS command, Lev Kujawski, 2022/07/06