[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 08/12] tests/vm: add 1GB extra memory per core
From: |
John Snow |
Subject: |
[PATCH v4 08/12] tests/vm: add 1GB extra memory per core |
Date: |
Fri, 8 Jul 2022 11:34:59 -0400 |
If you try to run a 16 or 32 threaded test, you're going to run out of
memory very quickly with qom-test and a few others. Bump the memory
limit to try to scale with larger-core machines.
Granted, this means that a 16 core processor is going to ask for 16GB,
but you *probably* meet that requirement if you have such a machine.
512MB per core didn't seem to be enough to avoid ENOMEM and SIGABRTs in
the test cases in practice on a six core machine; so I bumped it up to
1GB which seemed to help.
Add this magic in early to the configuration process so that the
config file, if provided, can still override it.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/vm/basevm.py | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index d7d0413df35..4fd9af10b7f 100644
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -99,6 +99,11 @@ def __init__(self, args, config=None):
self._source_path = args.source_path
# Allow input config to override defaults.
self._config = DEFAULT_CONFIG.copy()
+
+ # 1GB per core, minimum of 4. This is only a default.
+ mem = max(4, args.jobs)
+ self._config['memory'] = f"{mem}G"
+
if config != None:
self._config.update(config)
self.validate_ssh_keys()
--
2.34.3
- Re: [PATCH v4 09/12] tests/vm: Remove docker cross-compile test from CentOS VM, (continued)
- [PATCH v4 10/12] tests/qemu-iotests: hotfix for 307, 223 output, John Snow, 2022/07/08
- [PATCH v4 03/12] tests/vm: switch CentOS 8 to CentOS 8 Stream, John Snow, 2022/07/08
- [PATCH v4 07/12] tests/vm: remove duplicate 'centos' VM test, John Snow, 2022/07/08
- [PATCH v4 01/12] qga: treat get-guest-fsinfo as "best effort", John Snow, 2022/07/08
- [PATCH v4 04/12] tests/vm: switch centos.aarch64 to CentOS 8 Stream, John Snow, 2022/07/08
- [PATCH v4 08/12] tests/vm: add 1GB extra memory per core,
John Snow <=
- [PATCH v4 02/12] tests/vm: use 'cp' instead of 'ln' for temporary vm images, John Snow, 2022/07/08
- [PATCH v4 06/12] tests/vm: remove ubuntu.i386 VM test, John Snow, 2022/07/08
- [PATCH v4 11/12] tests/qemu-iotests: skip 108 when FUSE is not loaded, John Snow, 2022/07/08
- [PATCH v4 12/12] iotests: fix copy-before-write for macOS and FreeBSD, John Snow, 2022/07/08
- Re: [PATCH v4 00/12] Improve reliability of VM tests, John Snow, 2022/07/12
- Re: [PATCH v4 00/12] Improve reliability of VM tests, Thomas Huth, 2022/07/18