[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 00/14] scsi: add quirks and features to support m68k Macs
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH v3 00/14] scsi: add quirks and features to support m68k Macs |
Date: |
Tue, 12 Jul 2022 16:48:33 +0200 |
Queued, thanks (I was on vacation last week).
I am a bit scared about the mode_select_truncated quirk. My reading
of the code is that the MODE SELECT would fail anyway because the
page length does not match in scsi_disk_check_mode_select:
len = mode_sense_page(s, page, &p, 0);
if (len < 0 || len != expected_len) {
return -1;
}
Is that correct? If not, I'm not sure where I am wrong. If so,
I wonder if it is enough for the quirk to do just a "goto invalid_param;"
in place of invalid_param_len.
Thanks,
Paolo