[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 8/8] block: remove all unused ->can_set_aio_ctx and ->set
|
From: |
Emanuele Giuseppe Esposito |
|
Subject: |
Re: [RFC PATCH 8/8] block: remove all unused ->can_set_aio_ctx and ->set_aio_ctx callbacks |
|
Date: |
Mon, 18 Jul 2022 10:45:30 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
Am 15/07/2022 um 16:34 schrieb Hanna Reitz:
> On 12.07.22 23:19, Emanuele Giuseppe Esposito wrote:
>> Together with all _can_set_ and _set_ APIs, as they are not needed
>> anymore.
>>
>> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
>> ---
>> block.c | 196 -----------------------------
>> block/block-backend.c | 33 -----
>> blockjob.c | 35 ------
>> include/block/block-global-state.h | 9 --
>> include/block/block_int-common.h | 4 -
>> 5 files changed, 277 deletions(-)
>
> Looks good! I’d just like a follow-up commit that also drops
> bdrv_try_set_aio_context(), so it’s all gone (I think that’s the final
> remnant?).
>
It's the same for me, I thought renaming bdrv_try_set_aio_context was a
little bit unnecessary. You want to rename it to something else, or
directly call bdrv_child_try_change_aio_context?
I agree with the rest of comments in this series :)
Emanuele
- Re: [RFC PATCH 5/8] block: implement .change_aio_ctx in child_of_bds, (continued)
[RFC PATCH 8/8] block: remove all unused ->can_set_aio_ctx and ->set_aio_ctx callbacks, Emanuele Giuseppe Esposito, 2022/07/12
[RFC PATCH 3/8] RFC: block: use transactions as a replacement of ->{can_}set_aio_context(), Emanuele Giuseppe Esposito, 2022/07/12
[RFC PATCH 6/8] block-backend: implement .change_aio_ctx in child_root, Emanuele Giuseppe Esposito, 2022/07/12
[RFC PATCH 4/8] blockjob: implement .change_aio_ctx in child_job, Emanuele Giuseppe Esposito, 2022/07/12