[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 8/8] arm/aspeed: Replace mx25l25635e chip model
From: |
Andrew Jeffery |
Subject: |
Re: [PATCH v3 8/8] arm/aspeed: Replace mx25l25635e chip model |
Date: |
Mon, 25 Jul 2022 16:04:23 +0930 |
User-agent: |
Cyrus-JMAP/3.7.0-alpha0-757-gc3ad9c75d3-fm-20220722.001-gc3ad9c75 |
On Mon, 25 Jul 2022, at 16:02, Cédric Le Goater wrote:
> On 7/25/22 04:08, Andrew Jeffery wrote:
>>
>>
>> On Fri, 22 Jul 2022, at 16:06, Cédric Le Goater wrote:
>>> aspeed_machine_witherspoon_class_init(ObjectClass *oc, void *data)
>>> mc->desc = "OpenPOWER Witherspoon BMC (ARM1176)";
>>> amc->soc_name = "ast2500-a1";
>>> amc->hw_strap1 = WITHERSPOON_BMC_HW_STRAP1;
>>> - amc->fmc_model = "mx25l25635e";
>>> + amc->fmc_model = "mx25l25635f";
>>
>> The witherspoon I checked also reported mx25l25635e in dmesg for the
>> FMC.
>>
>> You do say "generally" in the commit message though.
>
> You can not tell from dmesg.
>
> The MX25L25635F and MX25L25635E models share the same JEDEC ID and
> the spi-nor flash device table only contains a mx25l25635e entry.
> The MX25L25635F is detected in mx25l25635_post_bfpt_fixups using SFDP.
>
> That's why I added this warning :
>
>
> https://github.com/legoater/linux/commit/934f0708ac597022cbf6c8d6f2ce91d55025e943
>
Oh righto, sorry for the noise.
- Re: [PATCH v3 1/8] m25p80: Add basic support for the SFDP command, (continued)
- [PATCH v3 2/8] m25p80: Add the n25q256a SFDP table, Cédric Le Goater, 2022/07/22
- [PATCH v3 7/8] m25p80: Add the w25q512jv SFPD table, Cédric Le Goater, 2022/07/22
- [PATCH v3 3/8] m25p80: Add the mx25l25635e SFPD table, Cédric Le Goater, 2022/07/22
- [PATCH v3 6/8] m25p80: Add the w25q256 SFPD table, Cédric Le Goater, 2022/07/22
- [PATCH v3 4/8] m25p80: Add the mx25l25635f SFPD table, Cédric Le Goater, 2022/07/22
- [PATCH v3 5/8] m25p80: Add the mx66l1g45g SFDP table, Cédric Le Goater, 2022/07/22
- [PATCH v3 8/8] arm/aspeed: Replace mx25l25635e chip model, Cédric Le Goater, 2022/07/22
- Re: [PATCH v3 0/8] m25p80: Add SFDP support, Cédric Le Goater, 2022/07/22