[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 03/15] block/blklogwrites: don't care to remove bs->file child
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v7 03/15] block/blklogwrites: don't care to remove bs->file child on failure |
Date: |
Tue, 26 Jul 2022 23:11:22 +0300 |
We don't need to remove bs->file, generic layer takes care of it. No
other driver cares to remove bs->file on failure by hand.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
---
block/blklogwrites.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/block/blklogwrites.c b/block/blklogwrites.c
index 12b4c3c8cf..cef9efe55d 100644
--- a/block/blklogwrites.c
+++ b/block/blklogwrites.c
@@ -254,10 +254,6 @@ fail_log:
s->log_file = NULL;
}
fail:
- if (ret < 0) {
- bdrv_unref_child(bs, bs->file);
- bs->file = NULL;
- }
qemu_opts_del(opts);
return ret;
}
--
2.25.1
- [PATCH v7 for-7.2 00/15] block: cleanup backing and file handling, Vladimir Sementsov-Ogievskiy, 2022/07/26
- [PATCH v7 01/15] block: BlockDriver: add .filtered_child_is_backing field, Vladimir Sementsov-Ogievskiy, 2022/07/26
- [PATCH v7 03/15] block/blklogwrites: don't care to remove bs->file child on failure,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v7 02/15] block: introduce bdrv_open_file_child() helper, Vladimir Sementsov-Ogievskiy, 2022/07/26
- [PATCH v7 04/15] test-bdrv-graph-mod: update test_parallel_perm_update test case, Vladimir Sementsov-Ogievskiy, 2022/07/26
- [PATCH v7 05/15] tests-bdrv-drain: bdrv_replace_test driver: declare supports_backing, Vladimir Sementsov-Ogievskiy, 2022/07/26
- [PATCH v7 07/15] block: document connection between child roles and bs->backing/bs->file, Vladimir Sementsov-Ogievskiy, 2022/07/26
- [PATCH v7 06/15] test-bdrv-graph-mod: fix filters to be filters, Vladimir Sementsov-Ogievskiy, 2022/07/26
- [PATCH v7 08/15] block/snapshot: stress that we fallback to primary child, Vladimir Sementsov-Ogievskiy, 2022/07/26
- [PATCH v7 10/15] Revert "block: Let replace_child_tran keep indirect pointer", Vladimir Sementsov-Ogievskiy, 2022/07/26
- [PATCH v7 15/15] block: refactor bdrv_remove_file_or_backing_child to bdrv_remove_child, Vladimir Sementsov-Ogievskiy, 2022/07/26
- [PATCH v7 13/15] block: Manipulate bs->file / bs->backing pointers in .attach/.detach, Vladimir Sementsov-Ogievskiy, 2022/07/26
- [PATCH v7 09/15] Revert "block: Let replace_child_noperm free children", Vladimir Sementsov-Ogievskiy, 2022/07/26