[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 19/22] parallels: naive implementation of parallels_co_pdiscard
From: |
Denis V. Lunev |
Subject: |
[PULL v2 19/22] parallels: naive implementation of parallels_co_pdiscard |
Date: |
Thu, 21 Sep 2023 09:54:57 +0200 |
* Discarding with backing stores is not supported by the format.
* There is no buffering/queueing of the discard operation.
* Only operations aligned to the cluster are supported.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 46 insertions(+)
diff --git a/block/parallels.c b/block/parallels.c
index a97fb8b506..1808029f14 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -537,6 +537,51 @@ parallels_co_readv(BlockDriverState *bs, int64_t
sector_num, int nb_sectors,
return ret;
}
+
+static int coroutine_fn GRAPH_RDLOCK
+parallels_co_pdiscard(BlockDriverState *bs, int64_t offset, int64_t bytes)
+{
+ int ret = 0;
+ uint32_t cluster, count;
+ BDRVParallelsState *s = bs->opaque;
+
+ /*
+ * The image does not support ZERO mark inside the BAT, which means that
+ * stale data could be exposed from the backing file.
+ */
+ if (bs->backing) {
+ return -ENOTSUP;
+ }
+
+ if (!QEMU_IS_ALIGNED(offset, s->cluster_size)) {
+ return -ENOTSUP;
+ } else if (!QEMU_IS_ALIGNED(bytes, s->cluster_size)) {
+ return -ENOTSUP;
+ }
+
+ cluster = offset / s->cluster_size;
+ count = bytes / s->cluster_size;
+
+ qemu_co_mutex_lock(&s->lock);
+ for (; count > 0; cluster++, count--) {
+ int64_t host_off = bat2sect(s, cluster) << BDRV_SECTOR_BITS;
+ if (host_off == 0) {
+ continue;
+ }
+
+ ret = bdrv_co_pdiscard(bs->file, host_off, s->cluster_size);
+ if (ret < 0) {
+ goto done;
+ }
+
+ parallels_set_bat_entry(s, cluster, 0);
+ bitmap_clear(s->used_bmap, host_cluster_index(s, host_off), 1);
+ }
+done:
+ qemu_co_mutex_unlock(&s->lock);
+ return ret;
+}
+
static void parallels_check_unclean(BlockDriverState *bs,
BdrvCheckResult *res,
BdrvCheckMode fix)
@@ -1417,6 +1462,7 @@ static BlockDriver bdrv_parallels = {
.bdrv_co_create = parallels_co_create,
.bdrv_co_create_opts = parallels_co_create_opts,
.bdrv_co_check = parallels_co_check,
+ .bdrv_co_pdiscard = parallels_co_pdiscard,
};
static void bdrv_parallels_init(void)
--
2.34.1
- [PULL v2 00/22] implement discard operation for Parallels images, Denis V. Lunev, 2023/09/21
- [PULL v2 01/22] parallels: fix formatting in bdrv_parallels initialization, Denis V. Lunev, 2023/09/21
- [PULL v2 05/22] parallels: return earler in fail_format branch in parallels_open(), Denis V. Lunev, 2023/09/21
- [PULL v2 06/22] parallels: return earlier from parallels_open() function on error, Denis V. Lunev, 2023/09/21
- [PULL v2 02/22] parallels: mark driver as supporting CBT, Denis V. Lunev, 2023/09/21
- [PULL v2 03/22] parallels: fix memory leak in parallels_open(), Denis V. Lunev, 2023/09/21
- [PULL v2 04/22] parallels: invent parallels_opts_prealloc() helper to parse prealloc opts, Denis V. Lunev, 2023/09/21
- [PULL v2 08/22] parallels: create mark_used() helper which sets bit in used bitmap, Denis V. Lunev, 2023/09/21
- [PULL v2 09/22] tests: ensure that image validation will not cure the corruption, Denis V. Lunev, 2023/09/21
- [PULL v2 07/22] parallels: refactor path when we need to re-check image in parallels_open, Denis V. Lunev, 2023/09/21
- [PULL v2 19/22] parallels: naive implementation of parallels_co_pdiscard,
Denis V. Lunev <=
- [PULL v2 13/22] tests: fix broken deduplication check in parallels format test, Denis V. Lunev, 2023/09/21
- [PULL v2 10/22] parallels: fix broken parallels_check_data_off(), Denis V. Lunev, 2023/09/21
- [PULL v2 15/22] parallels: accept multiple clusters in mark_used(), Denis V. Lunev, 2023/09/21
- [PULL v2 16/22] parallels: update used bitmap in allocate_cluster, Denis V. Lunev, 2023/09/21
- [PULL v2 14/22] tests: test self-cure of parallels image with duplicated clusters, Denis V. Lunev, 2023/09/21
- [PULL v2 12/22] parallels: collect bitmap of used clusters at open, Denis V. Lunev, 2023/09/21
- [PULL v2 21/22] parallels: naive implementation of parallels_co_pwrite_zeroes, Denis V. Lunev, 2023/09/21
- [PULL v2 17/22] parallels: naive implementation of allocate_clusters with used bitmap, Denis V. Lunev, 2023/09/21
- [PULL v2 11/22] parallels: add test which will validate data_off fixes through repair, Denis V. Lunev, 2023/09/21
- [PULL v2 18/22] parallels: improve readability of allocate_clusters, Denis V. Lunev, 2023/09/21