qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2 00/10] mirror: allow switching from background to active mode


From: Fiona Ebner
Subject: [PATCH v2 00/10] mirror: allow switching from background to active mode
Date: Mon, 9 Oct 2023 11:46:09 +0200

Changes in v2:
    * move bitmap to filter which allows to avoid draining when
      changing the copy mode
    * add patch to determine copy_to_target only once
    * drop patches returning redundant information upon query
    * update QEMU version in QAPI
    * update indentation in QAPI
    * update indentation in QAPI (like in a937b6aa73 ("qapi: Reformat
      doc comments to conform to current conventions"))
    * add patch to adapt iotest output

Discussion of v1:
https://lists.nongnu.org/archive/html/qemu-devel/2023-02/msg07216.html

With active mode, the guest write speed is limited by the synchronous
writes to the mirror target. For this reason, management applications
might want to start out in background mode and only switch to active
mode later, when certain conditions are met. This series adds a
block-job-change QMP command to achieve that, as well as
job-type-specific information when querying block jobs, which
can be used to decide when the switch should happen.

For now, only the direction background -> active is supported.

The information added upon querying is whether the target is actively
synced, the total data sent, and the remaining dirty bytes.

Initially, I tried to go for a more general 'job-change' command, but
I couldn't figure out a way to avoid mutual inclusion between
block-core.json and job.json.


Fiona Ebner (10):
  blockjob: introduce block-job-change QMP command
  block/mirror: set actively_synced even after the job is ready
  block/mirror: move dirty bitmap to filter
  block/mirror: determine copy_to_target only once
  mirror: implement mirror_change method
  qapi/block-core: use JobType for BlockJobInfo's type
  qapi/block-core: turn BlockJobInfo into a union
  blockjob: query driver-specific info via a new 'query' driver method
  mirror: return mirror-specific information upon query
  iotests: adapt test output for new mirror query property

 block/mirror.c                 | 95 +++++++++++++++++++++++-----------
 block/monitor/block-hmp-cmds.c |  4 +-
 blockdev.c                     | 14 +++++
 blockjob.c                     | 26 +++++++++-
 include/block/blockjob.h       | 11 ++++
 include/block/blockjob_int.h   | 10 ++++
 job.c                          |  1 +
 qapi/block-core.json           | 59 +++++++++++++++++++--
 qapi/job.json                  |  4 +-
 tests/qemu-iotests/109.out     | 24 ++++-----
 10 files changed, 199 insertions(+), 49 deletions(-)

-- 
2.39.2





reply via email to

[Prev in Thread] Current Thread [Next in Thread]