[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 12/20] parallels: Handle L1 entries equal to one
From: |
Alexander Ivanov |
Subject: |
[PATCH v2 12/20] parallels: Handle L1 entries equal to one |
Date: |
Thu, 19 Oct 2023 14:58:46 +0200 |
If all the bits in a dirty bitmap cluster are ones, the cluster shouldn't
be written. Instead the corresponding L1 entry should be set to 1.
Check if all bits in a memory region are ones and set 1 to L1 entries
corresponding clusters filled with ones.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels-ext.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/block/parallels-ext.c b/block/parallels-ext.c
index a0de4f1b07..ebda6b0a01 100644
--- a/block/parallels-ext.c
+++ b/block/parallels-ext.c
@@ -354,7 +354,7 @@ static void parallels_save_bitmap(BlockDriverState *bs,
BdrvDirtyBitmap *bitmap,
offset = 0;
while ((offset = bdrv_dirty_bitmap_next_dirty(bitmap, offset, bm_size)) >=
0) {
uint64_t idx = offset / limit;
- int64_t cluster_off, end, write_size;
+ int64_t cluster_off, end, write_size, first_zero;
offset = QEMU_ALIGN_DOWN(offset, limit);
end = MIN(bm_size, offset + limit);
@@ -367,6 +367,16 @@ static void parallels_save_bitmap(BlockDriverState *bs,
BdrvDirtyBitmap *bitmap,
memset(bm_buf + write_size, 0, s->cluster_size - write_size);
}
+ first_zero = bdrv_dirty_bitmap_next_zero(bitmap, offset, bm_size);
+ if (first_zero < 0) {
+ goto end;
+ }
+ if (first_zero - offset >= s->cluster_size) {
+ l1_table[idx] = 1;
+ offset = end;
+ continue;
+ }
+
cluster_off = parallels_allocate_host_clusters(bs, &alloc_size);
if (cluster_off <= 0) {
goto end;
--
2.34.1
- [PATCH v2 05/20] parallels: Set data_end value in parallels_check_leak(), (continued)
- [PATCH v2 05/20] parallels: Set data_end value in parallels_check_leak(), Alexander Ivanov, 2023/10/19
- [PATCH v2 03/20] parallels: Add mark_unused() helper, Alexander Ivanov, 2023/10/19
- [PATCH v2 08/20] parallels: Create used bitmap even if checks needed, Alexander Ivanov, 2023/10/19
- [PATCH v2 07/20] parallels: Add a note about used bitmap in parallels_check_duplicate(), Alexander Ivanov, 2023/10/19
- [PATCH v2 09/20] parallels: Make mark_used() and mark_unused() global functions, Alexander Ivanov, 2023/10/19
- [PATCH v2 10/20] parallels: Add dirty bitmaps saving, Alexander Ivanov, 2023/10/19
- [PATCH v2 12/20] parallels: Handle L1 entries equal to one,
Alexander Ivanov <=
- [PATCH v2 13/20] parallels: Make a loaded dirty bitmap persistent, Alexander Ivanov, 2023/10/19
- [PATCH v2 14/20] parallels: Reverse a conditional in parallels_check_leak() to reduce indents, Alexander Ivanov, 2023/10/19
- [PATCH v2 11/20] parallels: Let image extensions work in RW mode, Alexander Ivanov, 2023/10/19
- [PATCH v2 16/20] parallels: Check unused clusters in parallels_check_leak(), Alexander Ivanov, 2023/10/19
- [PATCH v2 17/20] parallels: Remove unnecessary data_end field, Alexander Ivanov, 2023/10/19
- [PATCH v2 18/20] tests: Add parallels images support to test 165, Alexander Ivanov, 2023/10/19
- [PATCH v2 19/20] tests: Turned on 256, 299, 304 and block-status-cache for parallels format, Alexander Ivanov, 2023/10/19
- [PATCH v2 15/20] parallels: Truncate images on the last used cluster, Alexander Ivanov, 2023/10/19
- [PATCH v2 20/20] tests: Add parallels format support to image-fleecing, Alexander Ivanov, 2023/10/19