Re: [PATCH 20/24] block: Add missing GRAPH_RDLOCK annotations

[Eric Blake]

On Fri, Oct 27, 2023 at 05:53:29PM +0200, Kevin Wolf wrote:
> This adds GRAPH_RDLOCK to some driver callbacks that are already called
> with the graph lock held, and which will need the annotation because
> they access bs->file, but don't have it yet.
> 
> This also covers a few callbacks that were not marked GRAPH_RDLOCK
> before, but where updating BlockDriver is trivially possible.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/qcow2.h                    | 11 ++++++-----
>  include/block/block_int-common.h | 17 +++++++++--------
>  block/blkdebug.c                 | 13 +++++--------
>  block/blkverify.c                |  2 +-
>  block/copy-before-write.c        |  2 +-
>  block/filter-compress.c          |  3 ++-
>  block/io.c                       |  2 ++
>  block/parallels.c                | 12 ++++--------
>  block/preallocate.c              |  4 ++--
>  block/qcow.c                     |  2 +-
>  block/qcow2.c                    |  4 ++--
>  block/qed.c                      | 10 ++++------
>  block/raw-format.c               | 16 ++++++++--------
>  block/snapshot-access.c          |  2 +-
>  block/vdi.c                      |  9 ++++-----
>  block/vhdx.c                     |  6 +++---
>  16 files changed, 55 insertions(+), 60 deletions(-)
>

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org