Re: [PATCH v5 1/6] virtio: split into vhost-user-base and vhost-user-device

[Alex Bennée]

"Michael S. Tsirkin" <mst@redhat.com> writes:

> On Thu, Oct 19, 2023 at 10:56:05AM +0100, Alex Bennée wrote:
>> Lets keep a cleaner split between the base class and the derived
>> vhost-user-device which we can use for generic vhost-user stubs. This
>> includes an update to introduce the vq_size property so the number of
>> entries in a virtq can be defined.
>> 
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Message-Id: <20231009095937.195728-2-alex.bennee@linaro.org>
>
> I applied but I think for this release we are better off just
> preventing users from instanciating these on command line -
> developers can always hack code to drop this.

I guess if a user doesn't read the documentation and makes up some
random numbers for the properties they deserve what they get?

> Can you post a patch please?

Is:

    /* comment out if you want to use backends qemu doesn't know about */
    .abstract = true,

really worth it?


-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro