[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes
From: |
David Woodhouse |
Subject: |
Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes |
Date: |
Sat, 11 Nov 2023 17:22:41 -0500 |
User-agent: |
K-9 Mail for Android |
On 11 November 2023 16:51:22 GMT-05:00, Andrew Cooper
<andrew.cooper3@citrix.com> wrote:
>On 11/11/2023 8:18 pm, David Woodhouse wrote:
>> On 11 November 2023 08:43:40 GMT-05:00, Andrew Cooper
>> <andrew.cooper3@citrix.com> wrote:
>>> Furthermore, the control domain doesn't always have the domid of 0.
>>>
>>> If qemu wants/needs to make changes like this, the control domain has to
>>> arrange for qemu's domain to have appropriate permissions on the nodes.
>> Right. And that's simple enough: if you are running QEMU in a domain which
>> doesn't have permission to create the backend directory and/or the frontend
>> nodes, don't ask it to *create* devices. In that case it is only able to
>> connect as the backend for devices which were created *for* it by the
>> toolstack.
>>
>> The criterion used in this patch series should be "did QEMU create this
>> device, or discover it".
>>
>
>Yeah, that sounds like the right approach.
I think we want to kill the xen_backend_set_device() function and instead set
the backend as a property of the XenDevice *before* realizing it.
Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes, Paul Durrant, 2023/11/12