[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 0/4] ide: implement simple legacy/native mode switching for PC
From: |
Mark Cave-Ayland |
Subject: |
[PATCH v3 0/4] ide: implement simple legacy/native mode switching for PCI IDE controllers |
Date: |
Thu, 16 Nov 2023 10:33:51 +0000 |
This series adds a simple implementation of legacy/native mode switching for PCI
IDE controllers and updates the via-ide device to use it.
The approach I take here is to add a new pci_ide_update_mode() function which
handles
management of the PCI BARs and legacy IDE ioports for each mode to avoid
exposing
details of the internal logic to individual PCI IDE controllers.
As noted in [1] this is extracted from a local WIP branch I have which contains
further work in this area. However for the moment I've kept it simple (and
restricted it to the via-ide device) which is good enough for Zoltan's PPC
images whilst paving the way for future improvements after 8.2.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
[1] https://lists.gnu.org/archive/html/qemu-devel/2023-10/msg05403.html
v3:
- Rebase onto master
- Move ide_portio_list[] and ide_portio_list2[] to IDE core to prevent
duplication in
hw/ide/pci.c
- Don't zero BARs when switching from native mode to legacy mode, instead
always force
them to read zero as suggested in the PCI IDE specification (note: this also
appears
to fix the fuloong2e machine booting from IDE)
- Add comments in pci_ide_update_mode() suggested by Kevin
- Drop the existing R-B and T-B tags: whilst this passes my local tests, the
behaviour
around zero BARs feels different enough here
v2:
- Rebase onto master
- Mask the bottom 4 bits of PCI_CLASS_PROG in pci_ide_update_mode() in patch 1
- Add patch 2 to remove the default BAR addresses to avoid confusion
- Don't set PCI_INTERRUPT_PIN directly in via_ide_reset() as it is already set
by pci_ide_update_mode() in patch 3, and reword the commit message accordingly
- Add Tested-By tags from Zoltan and Bernhard
Mark Cave-Ayland (4):
ide/ioport: move ide_portio_list[] and ide_portio_list2[] definitions
to IDE core
ide/pci: introduce pci_ide_update_mode() function
ide/via: don't attempt to set default BAR addresses
hw/ide/via: implement legacy/native mode switching
hw/ide/core.c | 12 ++++++
hw/ide/ioport.c | 12 ------
hw/ide/pci.c | 84 +++++++++++++++++++++++++++++++++++++++
hw/ide/via.c | 44 ++++++++++++++++----
include/hw/ide/internal.h | 3 ++
include/hw/ide/pci.h | 1 +
6 files changed, 137 insertions(+), 19 deletions(-)
--
2.39.2
- [PATCH v3 0/4] ide: implement simple legacy/native mode switching for PCI IDE controllers,
Mark Cave-Ayland <=
- [PATCH v3 1/4] ide/ioport: move ide_portio_list[] and ide_portio_list2[] definitions to IDE core, Mark Cave-Ayland, 2023/11/16
- [PATCH v3 3/4] ide/via: don't attempt to set default BAR addresses, Mark Cave-Ayland, 2023/11/16
- [PATCH v3 2/4] ide/pci: introduce pci_ide_update_mode() function, Mark Cave-Ayland, 2023/11/16
- [PATCH v3 4/4] hw/ide/via: implement legacy/native mode switching, Mark Cave-Ayland, 2023/11/16
- Re: [PATCH v3 0/4] ide: implement simple legacy/native mode switching for PCI IDE controllers, Kevin Wolf, 2023/11/16