[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/12] hw/xen: add get_frontend_path() method to XenDeviceCla
From: |
David Woodhouse |
Subject: |
Re: [PATCH 06/12] hw/xen: add get_frontend_path() method to XenDeviceClass |
Date: |
Tue, 21 Nov 2023 12:25:55 +0000 |
User-agent: |
Evolution 3.44.4-0ubuntu2 |
On Tue, 2023-10-24 at 14:29 +0100, David Woodhouse wrote:
>
> > > As a general rule (I'll be doing a bombing run on xen-bus once I get my
> > > patch queue down into single digits) we should never check 'if (*errp)'
> > > to check if a function had an error. It should *also* return a success
> > > or failure indication, and we should cope with errp being NULL.
> > >
> >
> > I'm pretty sure someone told me the exact opposite a few years back.
>
> Then they were wrong :)
cf. https://gitlab.com/qemu-project/qemu/-/commit/e3fe3988d7
"Whenever practical, also return a value that indicates success / failure"
smime.p7s
Description: S/MIME cryptographic signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 06/12] hw/xen: add get_frontend_path() method to XenDeviceClass,
David Woodhouse <=