qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 14/15] qapi: Move @String out of common.json to discourage re


From: Daniel P . Berrangé
Subject: Re: [PATCH 14/15] qapi: Move @String out of common.json to discourage reuse
Date: Wed, 7 Feb 2024 08:41:28 +0000
User-agent: Mutt/2.2.12 (2023-09-09)

On Mon, Feb 05, 2024 at 08:47:08AM +0100, Markus Armbruster wrote:
> Use of String is problematic, because it results in awkward interface
> documentation.  The previous commit cleaned up one instance.
> 
> Move String out of common.json next to its remaining users in net.json
> to discourage reuse elsewhere.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qapi/common.json     | 11 -----------
>  qapi/net.json        | 12 +++++++++++-
>  include/net/filter.h |  2 +-
>  3 files changed, 12 insertions(+), 13 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




reply via email to

[Prev in Thread] Current Thread [Next in Thread]