[Qemu-commits] [qemu/qemu] fb730c: linux-user: test, don't assert addr != test in pgb...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: fb730c8683807d549c4aa8dfc98e3d1d470fd784
      
https://github.com/qemu/qemu/commit/fb730c8683807d549c4aa8dfc98e3d1d470fd784
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-09-16 (Wed, 16 Sep 2020)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user: test, don't assert addr != test in pgb_reserved_va

On older kernels which don't implement MAP_FIXED_NOREPLACE the kernel
may still fail to give us the address we asked for despite having
already probed the map for a valid hole. Asserting isn't particularly
useful to the user so let us move the check up and expand the
error_report a little to give them a fighting chance of working around
the problem.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Cc: Bug 1895080 <1895080@bugs.launchpad.net>
Ameliorates: ee94743034
Message-Id: <20200915134317.11110-2-alex.bennee@linaro.org>


  Commit: b8761cfdd6a1fb0393dc0aa3737f9a01795ae4b0
      
https://github.com/qemu/qemu/commit/b8761cfdd6a1fb0393dc0aa3737f9a01795ae4b0
  Author: Max Reitz <mreitz@redhat.com>
  Date:   2020-09-16 (Wed, 16 Sep 2020)

  Changed paths:
    M tests/qemu-iotests/check

  Log Message:
  -----------
  iotests: Drop readlink -f

On macOS, (out of the box) readlink does not have -f.  We do not really
need readlink here, though, it was just a replacement for realpath
(which is not available on our BSD test systems), which we needed to
make the $(dirname) into an absolute path.

Instead of using either, just use "cd; pwd" like is done for
$source_iotests.

       ("iotests: Allow running from different directory")

Fixes: b1cbc33a3971b6bb005d5ac3569feae35a71de0f
Reported-by: Claudio Fontana <cfontana@suse.de>
Reported-by: Thomas Huth <thuth@redhat.com>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200914145606.94620-1-mreitz@redhat.com>
Message-Id: <20200915134317.11110-3-alex.bennee@linaro.org>


  Commit: 94ce373aa430117a2e42dfd9e7e316f518ee47b4
      
https://github.com/qemu/qemu/commit/94ce373aa430117a2e42dfd9e7e316f518ee47b4
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-09-16 (Wed, 16 Sep 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: move deprecated feature processing to supported_target

This is the common point at which we validate targets so it makes
sense to add_to deprecated_features here. It will make future target
deprecation easier as we only need to tweak one list.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200915134317.11110-4-alex.bennee@linaro.org>


  Commit: 3a5ae4a936c9b80ec137b569d08662ddbbd0c1a8
      
https://github.com/qemu/qemu/commit/3a5ae4a936c9b80ec137b569d08662ddbbd0c1a8
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-09-16 (Wed, 16 Sep 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: also skip deprecated targets with target-list-exclude

Now the user has to make an even more deliberate decision to
enable a deprecated target rather than getting it as a side effect of
using --target-exclude-list.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200915134317.11110-5-alex.bennee@linaro.org>


  Commit: 98db9a066748fdbbd4131fd874c04d40fd0aca4b
      
https://github.com/qemu/qemu/commit/98db9a066748fdbbd4131fd874c04d40fd0aca4b
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-09-16 (Wed, 16 Sep 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: clean-up the target-list-exclude logic

Rather than sed and loop just do a grep.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200915134317.11110-6-alex.bennee@linaro.org>


  Commit: 44bf7a3464f2249c585169667b85c0451d6b6bc3
      
https://github.com/qemu/qemu/commit/44bf7a3464f2249c585169667b85c0451d6b6bc3
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-09-16 (Wed, 16 Sep 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: include tilegx-linux-user in the deprecation logic

The target is already marked as deprecated in the documentation.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200915134317.11110-7-alex.bennee@linaro.org>


  Commit: 1c0c06b1ea29d6f81424011f9b69b77cb0ea87ce
      
https://github.com/qemu/qemu/commit/1c0c06b1ea29d6f81424011f9b69b77cb0ea87ce
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-09-16 (Wed, 16 Sep 2020)

  Changed paths:
    M .gitlab-ci.yml
    M .travis.yml

  Log Message:
  -----------
  gitlab: create a build-deprecated target

These targets might be deprecated but we should keep them building
before the final axe comes down. Lets keep them all in one place and
don't hold up the CI if they do fail. They are either poorly tested or
already flaky anyway.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20200915134317.11110-8-alex.bennee@linaro.org>


  Commit: 3ffc7f013763bf4fc50c3b403cbacca2bee68cfa
      
https://github.com/qemu/qemu/commit/3ffc7f013763bf4fc50c3b403cbacca2bee68cfa
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-09-16 (Wed, 16 Sep 2020)

  Changed paths:
    M .gitlab-ci.yml
    M .shippable.yml
    M configure

  Log Message:
  -----------
  configure: add [lm32|unicore32]-softmmu to deprecation logic

While we are at it move the few places where they are into the
deprecation build bucket.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200915134317.11110-9-alex.bennee@linaro.org>


  Commit: 3af984709398d61ecdcd32fb61295e6332d94392
      
https://github.com/qemu/qemu/commit/3af984709398d61ecdcd32fb61295e6332d94392
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-09-17 (Thu, 17 Sep 2020)

  Changed paths:
    M .gitlab-ci.yml
    M .shippable.yml
    M .travis.yml
    M configure
    M linux-user/elfload.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/stsquad/tags/pull-configure-fixes-160920-1' into staging

configure tweaks for deprecation

  - iotest fix for readlink -f
  - linux-user, report rather than assert on mmap failure
  - clean-up and re-factor the logic
  - add tilegx-linux-user to deprecated_targets_list
  - add [lm32|unicore32]-softmmu deprecated_targets_list
  - add a gitlab deprecated builds test

# gpg: Signature made Wed 16 Sep 2020 10:11:41 BST
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) 
<alex.bennee@linaro.org>" [full]
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* remotes/stsquad/tags/pull-configure-fixes-160920-1:
  configure: add [lm32|unicore32]-softmmu to deprecation logic
  gitlab: create a build-deprecated target
  configure: include tilegx-linux-user in the deprecation logic
  configure: clean-up the target-list-exclude logic
  configure: also skip deprecated targets with target-list-exclude
  configure: move deprecated feature processing to supported_target
  iotests: Drop readlink -f
  linux-user: test, don't assert addr != test in pgb_reserved_va

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/5e0a8fda65fc...3af984709398