qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 7851b2: hw/ide/piix: Remove redundant "piix3-


From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] 7851b2: hw/ide/piix: Remove redundant "piix3-ide-xen" devi...
Date: Thu, 09 Jun 2022 12:51:46 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 7851b21a8192750adecbcf6e8780a20de5891ad6
      
https://github.com/qemu/qemu/commit/7851b21a8192750adecbcf6e8780a20de5891ad6
  Author: Bernhard Beschow <shentey@gmail.com>
  Date:   2022-06-09 (Thu, 09 Jun 2022)

  Changed paths:
    M hw/i386/pc_piix.c
    M hw/ide/piix.c

  Log Message:
  -----------
  hw/ide/piix: Remove redundant "piix3-ide-xen" device class

Commit 0f8445820f11a69154309863960328dda3dc1ad4 'xen: piix reuse pci
generic class init function' already resolved redundant code which in
turn rendered piix3-ide-xen redundant.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Message-Id: <20220513180957.90514-2-shentey@gmail.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>


  Commit: 36902417460e3f9f1c63a79d802622fd774f1c30
      
https://github.com/qemu/qemu/commit/36902417460e3f9f1c63a79d802622fd774f1c30
  Author: Bernhard Beschow <shentey@gmail.com>
  Date:   2022-06-09 (Thu, 09 Jun 2022)

  Changed paths:
    M hw/ide/piix.c

  Log Message:
  -----------
  hw/ide/piix: Add some documentation to pci_piix3_xen_ide_unplug()

The comment is based on commit message
ae4d2eb273b167dad748ea4249720319240b1ac2 'xen-platform: add missing disk
unplug option'. Since it seems to describe design decisions and
limitations that still apply it seems worth having.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Message-Id: <20220513180957.90514-3-shentey@gmail.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>


  Commit: 6a8a8b62bdc8e3d7c5fc0f82ef4583707183b12f
      
https://github.com/qemu/qemu/commit/6a8a8b62bdc8e3d7c5fc0f82ef4583707183b12f
  Author: Bernhard Beschow <shentey@gmail.com>
  Date:   2022-06-09 (Thu, 09 Jun 2022)

  Changed paths:
    M hw/i386/xen/xen_platform.c
    M hw/ide/piix.c
    M include/hw/ide.h

  Log Message:
  -----------
  include/hw/ide: Unexport pci_piix3_xen_ide_unplug()

This function was declared in a generic and public header, implemented
in a device-specific source file but only used in xen_platform. Given its
'aux' parameter, this function is more xen-specific than piix-specific.
Also, the hardcoded magic constants seem to be generic and related to
PCIIDEState and IDEBus rather than piix.

Therefore, move this function to xen_platform, unexport it, and drop the
"piix3" in the function name as well.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Paul Durrant <paul@xen.org>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220513180957.90514-4-shentey@gmail.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>


  Commit: 9cc1bf1ebca550f8d90f967ccd2b6d2e00e81387
      
https://github.com/qemu/qemu/commit/9cc1bf1ebca550f8d90f967ccd2b6d2e00e81387
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-06-09 (Thu, 09 Jun 2022)

  Changed paths:
    M hw/i386/pc_piix.c
    M hw/i386/xen/xen_platform.c
    M hw/ide/piix.c
    M include/hw/ide.h

  Log Message:
  -----------
  Merge tag 'pull-xen-20220609' of 
https://xenbits.xen.org/git-http/people/aperard/qemu-dm into staging

Xen patches

- PIIX3-IDE Xen cleanup

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCgAdFiEE+AwAYwjiLP2KkueYDPVXL9f7Va8FAmKh/A8ACgkQDPVXL9f7
# Va80HAf/RfBfHiHQnZOiixu+drHNcyxHDqeEcd5OqWJssD/uwd/s+DfjUm7q4t3p
# AOOf3kczj+S7LomVi4CU0qW6/edY6Jyq37aIQnCwwG35/U297gyqQGaLftDRspWO
# quBGd/66+3wSttRDY9zuTvAWRX1IBk+7ON67TXQxnNyeE+JsstzkZw86939BO1L/
# Rp1LwwtNPS8rnT1YMSWBaFGjRbxOBzF/cRVLxwv+XBYJw/DGKVeB41I5MnNT+ZlP
# MC2PVr2wZM6ki9xYdivn8d4IKECgeXclK3YSOKlYNbWW8bVvFde9j/DMty7k2geE
# 8JMsdIGTvVbb9zwe85SaguWRWlArpA==
# =cyLu
# -----END PGP SIGNATURE-----
# gpg: Signature made Thu 09 Jun 2022 06:56:31 AM PDT
# gpg:                using RSA key F80C006308E22CFD8A92E7980CF5572FD7FB55AF
# gpg: Good signature from "Anthony PERARD <anthony.perard@gmail.com>" [unknown]
# gpg:                 aka "Anthony PERARD <anthony.perard@citrix.com>" 
[unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 5379 2F71 024C 600F 778A  7161 D8D5 7199 DF83 42C8
#      Subkey fingerprint: F80C 0063 08E2 2CFD 8A92  E798 0CF5 572F D7FB 55AF

* tag 'pull-xen-20220609' of 
https://xenbits.xen.org/git-http/people/aperard/qemu-dm:
  include/hw/ide: Unexport pci_piix3_xen_ide_unplug()
  hw/ide/piix: Add some documentation to pci_piix3_xen_ide_unplug()
  hw/ide/piix: Remove redundant "piix3-ide-xen" device class

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/028f2361d0c2...9cc1bf1ebca5



reply via email to

[Prev in Thread] Current Thread [Next in Thread]