qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] c8ddcd: dbus-display: fix test race when init


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] c8ddcd: dbus-display: fix test race when initializing p2p ...
Date: Tue, 19 Jul 2022 09:41:01 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: c8ddcdd6886b34d5d55d8d59973280e4c1b49195
      
https://github.com/qemu/qemu/commit/c8ddcdd6886b34d5d55d8d59973280e4c1b49195
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M ui/dbus.c

  Log Message:
  -----------
  dbus-display: fix test race when initializing p2p connection

The D-Bus connection starts processing messages before QEMU has the time
to set the object manager server. This is causing dbus-display-test to
fail randomly with:

ERROR:../tests/qtest/dbus-display-test.c:68:test_dbus_display_vm:
assertion failed
(qemu_dbus_display1_vm_get_name(QEMU_DBUS_DISPLAY1_VM(vm)) ==
"dbus-test"): (NULL == "dbus-test") ERROR

Use the delayed message processing flag and method to avoid that
situation.

(the bus connection doesn't need a fix, as the initialization is done
synchronously)

Reported-by: Robinson, Cole <crobinso@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Tested-by: Cole Robinson <crobinso@redhat.com>
Message-Id: <20220609152647.870373-1-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 3ef1497b46c57eba151fb1d0bdd8c8bff8a0f524
      
https://github.com/qemu/qemu/commit/3ef1497b46c57eba151fb1d0bdd8c8bff8a0f524
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M hw/i386/microvm.c

  Log Message:
  -----------
  microvm: turn off io reservations for pcie root ports

The pcie host bridge has no io window on microvm,
so io reservations will not work.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20220701091516.43489-1-kraxel@redhat.com>


  Commit: 84218892f05515d20347fde4506e1944eb11cb25
      
https://github.com/qemu/qemu/commit/84218892f05515d20347fde4506e1944eb11cb25
  Author: Mauro Matteo Cascella <mcascell@redhat.com>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M hw/usb/hcd-xhci.c

  Log Message:
  -----------
  usb/hcd-xhci: check slotid in xhci_wakeup_endpoint()

This prevents an OOB read (followed by an assertion failure in
xhci_kick_ep) when slotid > xhci->numslots.

Reported-by: Soul Chen <soulchen8650@gmail.com>
Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
Message-Id: <20220705174734.2348829-1-mcascell@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: f3a445b68e7ed1d9fe14e3c92cfec38b1ac97331
      
https://github.com/qemu/qemu/commit/f3a445b68e7ed1d9fe14e3c92cfec38b1ac97331
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M docs/system/devices/usb.rst

  Log Message:
  -----------
  usb: document guest-reset and guest-reset-all

Suggested-by: Michal Prívozník <mprivozn@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Message-Id: <20220711094437.3995927-2-kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 04fcb215b8e61042ecd592f4920fe96faf3de36b
      
https://github.com/qemu/qemu/commit/04fcb215b8e61042ecd592f4920fe96faf3de36b
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M docs/system/devices/usb.rst

  Log Message:
  -----------
  usb: document pcap (aka usb traffic capture)

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20220711094437.3995927-3-kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: c34a933802071aae5288e0aa3792756312e3da34
      
https://github.com/qemu/qemu/commit/c34a933802071aae5288e0aa3792756312e3da34
  Author: Felix xq Queißner <xq@random-projects.net>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M qapi/ui.json
    M qemu-options.hx
    M ui/gtk.c

  Log Message:
  -----------
  gtk: Add show_tabs=on|off command line option.

The patch adds "show_tabs" command line option for GTK ui similar to
"grab_on_hover". This option allows tabbed view mode to not have to be
enabled by hand at each start of the VM.

Signed-off-by: Felix "xq" Queißner <xq@random-projects.net>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220712133753.18937-1-xq@random-projects.net>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: d48125de38f48a61d6423ef6a01156d6dff9ee2c
      
https://github.com/qemu/qemu/commit/d48125de38f48a61d6423ef6a01156d6dff9ee2c
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M docs/system/devices/usb.rst
    M hw/i386/microvm.c
    M hw/usb/hcd-xhci.c
    M qapi/ui.json
    M qemu-options.hx
    M ui/dbus.c
    M ui/gtk.c

  Log Message:
  -----------
  Merge tag 'kraxel-20220719-pull-request' of https://gitlab.com/kraxel/qemu 
into staging

ui: dbus-display fix, new gtk config options.
usb: xhci fix, doc updates.
microvm: no pcie io reservations.

# gpg: Signature made Tue 19 Jul 2022 16:21:06 BST
# gpg:                using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* tag 'kraxel-20220719-pull-request' of https://gitlab.com/kraxel/qemu:
  gtk: Add show_tabs=on|off command line option.
  usb: document pcap (aka usb traffic capture)
  usb: document guest-reset and guest-reset-all
  usb/hcd-xhci: check slotid in xhci_wakeup_endpoint()
  microvm: turn off io reservations for pcie root ports
  dbus-display: fix test race when initializing p2p connection

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/3336c3b9b9a8...d48125de38f4



reply via email to

[Prev in Thread] Current Thread [Next in Thread]