[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 77e3f0: block/io_uring: add missing include f
|
From: |
Richard Henderson |
|
Subject: |
[Qemu-commits] [qemu/qemu] 77e3f0: block/io_uring: add missing include file |
|
Date: |
Tue, 02 Aug 2022 08:34:13 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 77e3f038af1764983087e3551a0fde9951952c4d
https://github.com/qemu/qemu/commit/77e3f038af1764983087e3551a0fde9951952c4d
Author: Jinhao Fan <fanjinhao21s@ict.ac.cn>
Date: 2022-08-02 (Tue, 02 Aug 2022)
Changed paths:
M block/io_uring.c
Log Message:
-----------
block/io_uring: add missing include file
The commit "Use io_uring_register_ring_fd() to skip fd operations" uses
warn_report but did not include the header file "qemu/error-report.h".
This causes "error: implicit declaration of function ‘warn_report’".
Include this header file.
Fixes: e2848bc574 ("Use io_uring_register_ring_fd() to skip fd operations")
Signed-off-by: Jinhao Fan <fanjinhao21s@ict.ac.cn>
Message-Id: <20220721065645.577404-1-fanjinhao21s@ict.ac.cn>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Commit: e7156ff7cb3ea79c5c859168484a216c431bdd5a
https://github.com/qemu/qemu/commit/e7156ff7cb3ea79c5c859168484a216c431bdd5a
Author: Xie Yongji <xieyongji@bytedance.com>
Date: 2022-08-02 (Tue, 02 Aug 2022)
Changed paths:
M subprojects/libvduse/libvduse.c
Log Message:
-----------
libvduse: Fix the incorrect function name
In vduse_name_is_valid(), we actually check whether
the name is invalid or not. So let's change the
function name to vduse_name_is_invalid() to match
the behavior.
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20220706095624.328-2-xieyongji@bytedance.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Commit: d9cf16c0bee5b97fb76e0e1ad915a22bec0031b9
https://github.com/qemu/qemu/commit/d9cf16c0bee5b97fb76e0e1ad915a22bec0031b9
Author: Xie Yongji <xieyongji@bytedance.com>
Date: 2022-08-02 (Tue, 02 Aug 2022)
Changed paths:
M subprojects/libvduse/libvduse.c
Log Message:
-----------
libvduse: Replace strcpy() with strncpy()
Coverity reported a string overflow issue since we copied
"name" to "dev_config->name" without checking the length.
This should be a false positive since we already checked
the length of "name" in vduse_name_is_invalid(). But anyway,
let's replace strcpy() with strncpy() (as a general library,
we'd like to minimize dependencies on other libraries, so we
didn't use g_strlcpy() here) to fix the coverity complaint.
Fixes: Coverity CID 1490224
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20220706095624.328-3-xieyongji@bytedance.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Commit: 630179b7f7d147ee0f7d396e71775b60a16f46a1
https://github.com/qemu/qemu/commit/630179b7f7d147ee0f7d396e71775b60a16f46a1
Author: Xie Yongji <xieyongji@bytedance.com>
Date: 2022-08-02 (Tue, 02 Aug 2022)
Changed paths:
M subprojects/libvduse/libvduse.c
Log Message:
-----------
libvduse: Pass positive value to strerror()
The value passed to strerror() should be positive.
So let's fix it.
Fixes: Coverity CID 1490226, 1490223
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20220706095624.328-4-xieyongji@bytedance.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Commit: fd8a68ad6823d33bedeba20a22857867a1c3890e
https://github.com/qemu/qemu/commit/fd8a68ad6823d33bedeba20a22857867a1c3890e
Author: Lev Kujawski <lkujaw@member.fsf.org>
Date: 2022-08-02 (Tue, 02 Aug 2022)
Changed paths:
M hw/block/hd-geometry.c
Log Message:
-----------
hw/block/hd-geometry: Do not override specified bios-chs-trans
For small disk images (<4 GiB), QEMU and SeaBIOS default to the
LARGE/ECHS disk translation method, but it is not uncommon for other
BIOS software to use LBA in these cases as well. Some operating
system boot loaders (e.g., NT 4) do not handle LARGE translations
outside of fixed configurations. See, e.g., Q154052:
"When starting an x86 based computer, Ntdetect.com retrieves and
stores Interrupt 13 information. . . If the disk controller is using a
32 sector/64 head translation scheme, this boundary will be 1 GB. If
the controller uses 63 sector/255 head translation [AUTHOR: i.e.,
LBA], the limit will be 4 GB."
To accommodate these situations, hd_geometry_guess() now follows the
disk translation specified by the user even when the ATA disk geometry
is guessed.
hd_geometry_guess():
* Only set the disk translation when translation is AUTO.
* Show the soon-to-be active translation (*ptrans) in the trace rather
than what was guessed.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/56
Buglink: https://bugs.launchpad.net/qemu/+bug/1745312
Signed-off-by: Lev Kujawski <lkujaw@member.fsf.org>
Message-Id: <20220707204045.999544-1-lkujaw@member.fsf.org>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Commit: e13fe274bfbc4c5b338854a3519a64b84c2d5517
https://github.com/qemu/qemu/commit/e13fe274bfbc4c5b338854a3519a64b84c2d5517
Author: Cole Robinson <crobinso@redhat.com>
Date: 2022-08-02 (Tue, 02 Aug 2022)
Changed paths:
M tests/qemu-iotests/common.rc
Log Message:
-----------
qemu-iotests: Discard stderr when probing devices
qemu-iotests fails in the following setup:
./configure --enable-modules --enable-smartcard \
--target-list=x86_64-softmmu,s390x-softmmu
make
cd build
QEMU_PROG=`pwd`/s390x-softmmu/qemu-system-s390x \
../tests/check-block.sh qcow2
...
--- /home/crobinso/src/qemu/tests/qemu-iotests/127.out
+++ /home/crobinso/src/qemu/build/tests/qemu-iotests/scratch/127.out.bad
@@ -1,4 +1,18 @@
QA output created by 127
+Failed to open module: /home/crobinso/src/qemu/build/hw-usb-smartcard.so:
undefined symbol: ccid_card_ccid_attach
...
--- /home/crobinso/src/qemu/tests/qemu-iotests/267.out
+++ /home/crobinso/src/qemu/build/tests/qemu-iotests/scratch/267.out.bad
@@ -1,4 +1,11 @@
QA output created by 267
+Failed to open module: /home/crobinso/src/qemu/build/hw-usb-smartcard.so:
undefined symbol: ccid_card_ccid_attach
The stderr spew is its own known issue, but seems like iotests should
be discarding stderr in this case.
Signed-off-by: Cole Robinson <crobinso@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Commit: 21b1d974595b3986c68fe80a1f7e9b87886d4bae
https://github.com/qemu/qemu/commit/21b1d974595b3986c68fe80a1f7e9b87886d4bae
Author: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Date: 2022-08-02 (Tue, 02 Aug 2022)
Changed paths:
M include/qemu/main-loop.h
Log Message:
-----------
main loop: add missing documentation links to GS/IO macros
If we go directly to GLOBAL_STATE_CODE, IO_CODE or IO_OR_GS_CODE
definition, we just find that they "mark and check that the function
is part of the {category} API".
However, ther is no definition on what {category} API is, they are
in include/block/block-*.h
Therefore, add a comment that refers to such documentation.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Message-Id: <20220609122206.1016936-1-eesposit@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Commit: 0399521e53336bd2cdc15482bca0ffd3493fdff6
https://github.com/qemu/qemu/commit/0399521e53336bd2cdc15482bca0ffd3493fdff6
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2022-08-02 (Tue, 02 Aug 2022)
Changed paths:
M block/io_uring.c
M hw/block/hd-geometry.c
M include/qemu/main-loop.h
M subprojects/libvduse/libvduse.c
M tests/qemu-iotests/common.rc
Log Message:
-----------
Merge tag 'for-upstream' of git://repo.or.cz/qemu/kevin into staging
Block layer patches
- libvduse: Coverity fixes
- hd-geometry: Fix ignored bios-chs-trans setting
- io_uring: Fix compiler warning (missing #include)
- main loop: add missing documentation links to GS/IO macros
- qemu-iotests: Discard stderr when probing devices
# -----BEGIN PGP SIGNATURE-----
#
# iQJFBAABCAAvFiEE3D3rFZqa+V09dFb+fwmycsiPL9YFAmLpKDURHGt3b2xmQHJl
# ZGhhdC5jb20ACgkQfwmycsiPL9ZMcA//buzWQl/AFL2VT5Fy3WpFCYDVp5mTPJ2q
# bgkhCpn6i7UXIkML53hygfm7LN9Fj8Q8Ld4ljkETzljJajS3zsXvyY6bgNevQutX
# 8WvkcUNWMb96DEgetInak2ebH6lhti6/V7lBfjNFG1yC2s8l+JoWIPqWfJqohdiN
# D4+loa/wQx1ZS3TgKq8zAxfi5qbbGxRTZQUvuCJNYRryRQmJsZH380DzlIqkRJWt
# b3rM7m9ElSpmcmwmztWkdK4E/2VYGknUQOnRpY0AUSUTcm/kaP7EVwh61+TdjlKL
# NZxvZ08kenGFTBEA9z3ahnggcLypj4IYU3DB29CiJLjMjCb0s7tMwc8USYajN+GA
# iDqkbK14mDd8auRDVbVcmnq34xzS0rJocpzT0Jo9zYo7oGe/r+JjaVWmWq0pZ2SE
# QQuSPZXZokUdpL6E5X05+JZ+u6+G+iQz9UOhNpwmKB1ajiXUVKIst/SctpyKedOr
# cJWB34tQxQIFB57s6K7wVMbSWPIumTwQc08EX0HoicT9pUMN7s+Z1jrCufudZ0ot
# gx95v7gBDZZDsJim5qi3znA8tqnUmtL0yxkUVgv7LdQfIleEnEFfutFJpq/7VFe9
# WRzXBQJPU451jF7Gvj/StA3+05qMr22mXW4CX6t96Ud6QHiR0mUBSGPRzYusIV4d
# KYOjySU7cOg=
# =axCN
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 02 Aug 2022 06:35:49 AM PDT
# gpg: using RSA key DC3DEB159A9AF95D3D7456FE7F09B272C88F2FD6
# gpg: issuer "kwolf@redhat.com"
# gpg: Good signature from "Kevin Wolf <kwolf@redhat.com>" [full]
* tag 'for-upstream' of git://repo.or.cz/qemu/kevin:
main loop: add missing documentation links to GS/IO macros
qemu-iotests: Discard stderr when probing devices
hw/block/hd-geometry: Do not override specified bios-chs-trans
libvduse: Pass positive value to strerror()
libvduse: Replace strcpy() with strncpy()
libvduse: Fix the incorrect function name
block/io_uring: add missing include file
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Compare: https://github.com/qemu/qemu/compare/9b00d2790195...0399521e5333